From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21825 invoked by alias); 2 Jun 2011 01:04:06 -0000 Received: (qmail 21817 invoked by uid 22791); 2 Jun 2011 01:04:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jun 2011 01:03:50 +0000 Received: from kpbe14.cbf.corp.google.com (kpbe14.cbf.corp.google.com [172.25.105.78]) by smtp-out.google.com with ESMTP id p5213m3k032389; Wed, 1 Jun 2011 18:03:48 -0700 Received: from nabu.mtv.corp.google.com (nabu.mtv.corp.google.com [172.18.110.158]) by kpbe14.cbf.corp.google.com with ESMTP id p5213kP0006647; Wed, 1 Jun 2011 18:03:46 -0700 Received: by nabu.mtv.corp.google.com (Postfix, from userid 68019) id 35A3D15C1BE; Wed, 1 Jun 2011 18:03:45 -0700 (PDT) To: reply@codereview.appspotmail.com, dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: [google] Improve locus information during if-conversion (issue4526101) Message-Id: <20110602010346.35A3D15C1BE@nabu.mtv.corp.google.com> Date: Thu, 02 Jun 2011 01:04:00 -0000 From: singhai@google.com (Sharad Singhai) X-System-Of-Record: true Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00119.txt.bz2 This patch improves locus information during the if-conversion. Okay for google/main? Thanks, Sharad 2011-06-01 Sharad Singhai Google Ref 39994 * ifcvt.c (noce_try_cmove_arith): Use the locus information from the if-statment rather than the then path. Index: ifcvt.c =================================================================== --- ifcvt.c (revision 174547) +++ ifcvt.c (working copy) @@ -1670,7 +1670,7 @@ if (!tmp) return FALSE; - emit_insn_before_setloc (tmp, if_info->jump, INSN_LOCATOR (if_info->insn_a)); + emit_insn_before_setloc (tmp, if_info->jump, INSN_LOCATOR (if_info->jump)); return TRUE; end_seq_and_fail: -- This patch is available for review at http://codereview.appspot.com/4526101