From: Jack Howarth <howarth@bromo.med.uc.edu>
To: Bernd Schmidt <bernds@codesourcery.com>
Cc: Alexandre Oliva <aoliva@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: Initialize previous in read_state_param_structs
Date: Sat, 04 Jun 2011 03:16:00 -0000 [thread overview]
Message-ID: <20110604031612.GA7742@bromo.med.uc.edu> (raw)
In-Reply-To: <4DE370EA.1000501@codesourcery.com>
On Mon, May 30, 2011 at 12:26:50PM +0200, Bernd Schmidt wrote:
> On 05/30/2011 11:51 AM, Alexandre Oliva wrote:
> > Bootstrap-O3 complains about uninitialized uses of this variable in
> > gengtype-state.c. The variable can never actually be used before
> > initialization, but GCC is not smart enough to realize that.
> > read_state_structures, just before the function at hand, has a similar
> > loop and it zero-initializes both head and previous, so I adjusted the
> > affected function to follow the same pattern and avoid the bogus
> > warning. Regstrapped on x86_64-linux-gnu and i686-pc-linux-gnu. Ok to
> > install?
>
> Ok. Alternatively you could fix the warning and shorten the code using
> the pprev trick.
>
>
> Bernd
Alexandre,
Since your original patch was approved, are you checking in
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02304.html? Currently the
-O3 bootstrap is still broken without it.
Jack
next prev parent reply other threads:[~2011-06-04 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 10:56 Alexandre Oliva
2011-05-30 11:50 ` Bernd Schmidt
2011-06-04 3:16 ` Jack Howarth [this message]
2011-06-04 10:21 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110604031612.GA7742@bromo.med.uc.edu \
--to=howarth@bromo.med.uc.edu \
--cc=aoliva@redhat.com \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).