From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5059 invoked by alias); 4 Jun 2011 03:16:29 -0000 Received: (qmail 5050 invoked by uid 22791); 4 Jun 2011 03:16:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sat, 04 Jun 2011 03:16:14 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id 1ABCEB005D; Fri, 3 Jun 2011 23:16:13 -0400 (EDT) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id p543GCgX007753; Fri, 3 Jun 2011 23:16:12 -0400 Date: Sat, 04 Jun 2011 03:16:00 -0000 From: Jack Howarth To: Bernd Schmidt Cc: Alexandre Oliva , gcc-patches@gcc.gnu.org Subject: Re: Initialize previous in read_state_param_structs Message-ID: <20110604031612.GA7742@bromo.med.uc.edu> References: <4DE370EA.1000501@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DE370EA.1000501@codesourcery.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00291.txt.bz2 On Mon, May 30, 2011 at 12:26:50PM +0200, Bernd Schmidt wrote: > On 05/30/2011 11:51 AM, Alexandre Oliva wrote: > > Bootstrap-O3 complains about uninitialized uses of this variable in > > gengtype-state.c. The variable can never actually be used before > > initialization, but GCC is not smart enough to realize that. > > read_state_structures, just before the function at hand, has a similar > > loop and it zero-initializes both head and previous, so I adjusted the > > affected function to follow the same pattern and avoid the bogus > > warning. Regstrapped on x86_64-linux-gnu and i686-pc-linux-gnu. Ok to > > install? > > Ok. Alternatively you could fix the warning and shorten the code using > the pprev trick. > > > Bernd Alexandre, Since your original patch was approved, are you checking in http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02304.html? Currently the -O3 bootstrap is still broken without it. Jack