From: "Peter O'Gorman" <pogma@thewrittenword.com>
To: gcc-patches@gcc.gnu.org
Cc: dje.gcc@gmail.com, bkorb@gnu.org
Subject: AIX net/if_arp.h include fix for struct fc_softc
Date: Mon, 06 Jun 2011 04:16:00 -0000 [thread overview]
Message-ID: <20110606041634.GA6074@tw2.lan> (raw)
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
Hi,
We ran across an issue with qt-4.7 built with gcc-4.4 on AIX 5.2, 5.3,
6.1, and 7.1 where some static constructors were not being called. It
turned out to be a header file issue, see, for example,
https://www.ibm.com/developerworks/forums/thread.jspa?threadID=211873&tstart=-2
Using fixincludes to fix the header allows us to build a working qt.
The erroneous struct declaration is:
struct fc_softc {
struct arpcom fc_ac; /* FCS common part */
struct ndd *nddp; /* returned from NS */
int(*efcnet_arp_fct)
(struct ndd *, struct mbuf *); /* efcnet_arp function address */
} *fc_softc ;
when fixed it becomes:
typedef struct _fc_softc {
struct arpcom fc_ac; /* FCS common part */
struct ndd *nddp; /* returned from NS */
int(*efcnet_arp_fct)
(struct ndd *, struct mbuf *); /* efcnet_arp function address */
} *fc_softc ;
David, do you have any idea if this is what it's supposed to be?
Ok for trunk?
Peter
--
Peter O'Gorman
pogma@thewrittenword.com
[-- Attachment #2: aix_fc_softc.patch --]
[-- Type: text/plain, Size: 998 bytes --]
Index: ChangeLog
===================================================================
--- ChangeLog (revision 174678)
2011-??-?? Peter O'Gorman <pogma@thewrittenword.com>
* inclhack.def (aix_net_if_arp): New fix.
* fixincl.x: Regenerate.
* tests/base/net/if_arp.h [AIX_NET_IF_ARP_CHECK]: New test.
Index: inclhack.def
===================================================================
--- inclhack.def (revision 174678)
+++ inclhack.def (working copy)
@@ -369,6 +369,19 @@
test_text = "#define _Complex_I __I\n";
};
+/*
+ * net/if_arp.h defines a variable fc_softc instead of adding a
+ * typedef for the struct on AIX 5.2, 5.3, 6.1 and 7.1
+ */
+fix = {
+ hackname = aix_net_if_arp;
+ mach = "*-*-aix*";
+ files = "net/if_arp.h";
+ select = "^struct fc_softc \\{";
+ c_fix = format;
+ c_fix_arg = "typedef struct _fc_softc {";
+ test_text = "struct fc_softc {";
+};
/*
* pthread.h on AIX 4.3.3 tries to define a macro without whitspace
next reply other threads:[~2011-06-06 4:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 4:16 Peter O'Gorman [this message]
2011-06-06 14:11 ` Bruce Korb
2011-06-06 15:05 ` David Edelsohn
2011-06-06 16:17 ` Peter O'Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606041634.GA6074@tw2.lan \
--to=pogma@thewrittenword.com \
--cc=bkorb@gnu.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).