public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Basile Starynkevitch <basile@starynkevitch.net>
To: Bruce Korb <bruce.korb@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Patch: aesthetics for gcc/cp/cxx-pretty-print.c
Date: Mon, 06 Jun 2011 04:31:00 -0000	[thread overview]
Message-ID: <20110606063057.4a9f5130.basile@starynkevitch.net> (raw)
In-Reply-To: <4DEC38CC.1080006@gmail.com>

On Sun, 05 Jun 2011 19:17:48 -0700
Bruce Korb <bruce.korb@gmail.com> wrote:

> It also caused a code analysis tool to wander off into the weeds.
> +      if (DECL_NONSTATIC_MEMBER_FUNCTION_P (t))
> +        pp_cxx_decl_specifier_seq (pp, TREE_TYPE (TREE_TYPE (t))), break;
> +      /* FALLTHROUGH */


I believe the usual GCC style is using braces, e.g

      if (DECL_NONSTATIC_MEMBER_FUNCTION_P (t))
        {
          pp_cxx_decl_specifier_seq (pp, TREE_TYPE (TREE_TYPE (t)));
          break;
        }
      /* FALLTHROUGH */


-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

  reply	other threads:[~2011-06-06  4:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06  2:18 Bruce Korb
2011-06-06  4:31 ` Basile Starynkevitch [this message]
2011-06-07 16:01 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110606063057.4a9f5130.basile@starynkevitch.net \
    --to=basile@starynkevitch.net \
    --cc=bruce.korb@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).