From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16839 invoked by alias); 6 Jun 2011 04:31:19 -0000 Received: (qmail 16827 invoked by uid 22791); 6 Jun 2011 04:31:16 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC,TVD_RCVD_IP X-Spam-Check-By: sourceware.org Received: from 195-14-0-142.nuxit.net (HELO de558.ispfr.net) (195.14.0.142) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jun 2011 04:31:01 +0000 Received: from ours.starynkevitch.net ([213.41.244.95] helo=glinka.lesours) by de558.ispfr.net with smtp (Exim 4.72) (envelope-from ) id 1QTRSs-00020q-PK; Mon, 06 Jun 2011 06:30:59 +0200 Date: Mon, 06 Jun 2011 04:31:00 -0000 From: Basile Starynkevitch To: Bruce Korb Cc: GCC Patches Subject: Re: Patch: aesthetics for gcc/cp/cxx-pretty-print.c Message-Id: <20110606063057.4a9f5130.basile@starynkevitch.net> In-Reply-To: <4DEC38CC.1080006@gmail.com> References: <4DEC38CC.1080006@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00355.txt.bz2 On Sun, 05 Jun 2011 19:17:48 -0700 Bruce Korb wrote: > It also caused a code analysis tool to wander off into the weeds. > + if (DECL_NONSTATIC_MEMBER_FUNCTION_P (t)) > + pp_cxx_decl_specifier_seq (pp, TREE_TYPE (TREE_TYPE (t))), break; > + /* FALLTHROUGH */ I believe the usual GCC style is using braces, e.g if (DECL_NONSTATIC_MEMBER_FUNCTION_P (t)) { pp_cxx_decl_specifier_seq (pp, TREE_TYPE (TREE_TYPE (t))); break; } /* FALLTHROUGH */ -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basilestarynkevitchnet mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mine, sont seulement les miennes} ***