From: "Peter O'Gorman" <pogma@thewrittenword.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org, bkorb@gnu.org
Subject: Re: AIX net/if_arp.h include fix for struct fc_softc
Date: Mon, 06 Jun 2011 16:17:00 -0000 [thread overview]
Message-ID: <20110606161655.GG6074@tw2.lan> (raw)
In-Reply-To: <BANLkTi=2WdGA7Q-3WVieHoFKhz0rSGgugQ@mail.gmail.com>
On Mon, Jun 06, 2011 at 11:05:25AM -0400, David Edelsohn wrote:
> > David, do you have any idea if this is what it's supposed to be?
> >
> > Ok for trunk?
>
> The header certainly does not make sense as is and does not follow AIX
> header file conventions. typedef is the only thing that makes sense,
> which was confirmed by some other AIX developer with whom I checked.
> (I would have expected fc_softc_t as well if it was intended as a
> typedef, but that's a separate issue.)
>
> This change is okay.
Thanks, committed in r174707 with Bruce's change to the test.
>
> I will try to find the AIX header owners to fix the problem as well.
That would be great.
Peter
--
Peter O'Gorman
pogma@thewrittenword.com
prev parent reply other threads:[~2011-06-06 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 4:16 Peter O'Gorman
2011-06-06 14:11 ` Bruce Korb
2011-06-06 15:05 ` David Edelsohn
2011-06-06 16:17 ` Peter O'Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606161655.GG6074@tw2.lan \
--to=pogma@thewrittenword.com \
--cc=bkorb@gnu.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).