From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6978 invoked by alias); 6 Jun 2011 16:17:36 -0000 Received: (qmail 6460 invoked by uid 22791); 6 Jun 2011 16:17:20 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail1.thewrittenword.com (HELO mail1.thewrittenword.com) (69.67.212.77) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jun 2011 16:16:58 +0000 Received: from mail1.il.thewrittenword.com (emma-internal-gw.il.thewrittenword.com [192.168.13.25]) by mail1.thewrittenword.com (Postfix) with ESMTP id B351D5C21; Mon, 6 Jun 2011 16:45:10 +0000 (UTC) X-DKIM: Sendmail DKIM Filter v2.4.4 mail1.thewrittenword.com B351D5C21 Received: from tw2.lan (unknown [192.168.1.254]) by mail1.il.thewrittenword.com (Postfix) with ESMTP id 47934A15; Mon, 6 Jun 2011 16:16:57 +0000 (UTC) Received: from tw2.lan (tw2.lan [127.0.0.1]) by tw2.lan (8.14.4/8.14.4) with ESMTP id p56GGu4r032394; Mon, 6 Jun 2011 11:16:56 -0500 Received: (from pogma@localhost) by tw2.lan (8.14.4/8.14.4/Submit) id p56GGtop032393; Mon, 6 Jun 2011 11:16:55 -0500 Date: Mon, 06 Jun 2011 16:17:00 -0000 From: "Peter O'Gorman" To: David Edelsohn Cc: gcc-patches@gcc.gnu.org, bkorb@gnu.org Subject: Re: AIX net/if_arp.h include fix for struct fc_softc Message-ID: <20110606161655.GG6074@tw2.lan> References: <20110606041634.GA6074@tw2.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00427.txt.bz2 On Mon, Jun 06, 2011 at 11:05:25AM -0400, David Edelsohn wrote: > > David, do you have any idea if this is what it's supposed to be? > > > > Ok for trunk? > > The header certainly does not make sense as is and does not follow AIX > header file conventions. typedef is the only thing that makes sense, > which was confirmed by some other AIX developer with whom I checked. > (I would have expected fc_softc_t as well if it was intended as a > typedef, but that's a separate issue.) > > This change is okay. Thanks, committed in r174707 with Bruce's change to the test. > > I will try to find the AIX header owners to fix the problem as well. That would be great. Peter -- Peter O'Gorman pogma@thewrittenword.com