From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>,
gcc-patches@gcc.gnu.org, Richard Guenther <rguenther@suse.de>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)
Date: Thu, 09 Jun 2011 10:00:00 -0000 [thread overview]
Message-ID: <20110609095436.GA10734@kam.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTikSOs5vak+nmEc1Yrro9Om0_g8ZxQ@mail.gmail.com>
> On Thu, Jun 9, 2011 at 9:14 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> > Mike Stump <mikestump@comcast.net> writes:
> >
> >> On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
> >>> Â * lto.c (promote_var): Only set VISIBILITY_HIDDEN if
> >>> Â Â Â HAVE_GAS_HIDDEN.
> >>
> >> This looks wrong, there are more things that have visibility than those things that use GAS and have .hidden. Â Darwin I think is one of them. Â ? Â cygming.h seems to be another.
> >
> > Now that Darwin has been switched to define HAVE_GAS_HIDDEN, is the
> > lto.c part ok?
>
> Honza? I think if we are not marking the symbols hidden we "break"
> LTO in the way that we suddenly export local static symbols. So no,
Yes, on targets that do have concept of hidden symbols we ought to use the flag.
> I don't think we want to do that - but then we need another way to
> make it possible to access previously local statics from a different
> LTO partition.
I guess if we want to support targets that has nothing similar to hidden, we
can go for the random seed based mangling and simply export the nonsentially
named symbols.
Honza
>
> Richard.
>
> > I've re-bootstrapped both patches together on i386-apple-darwin9.8.0,
> > powerpc-apple-darwin9.8.0, i386-pc-solaris2.8 and i386-pc-solaris2.11
> > without regressions; as expected the failure on Solaris 8/x86 is gone.
> >
> > Thanks.
> > Â Â Â Â Rainer
> >
> > --
> > -----------------------------------------------------------------------------
> > Rainer Orth, Center for Biotechnology, Bielefeld University
> >
next prev parent reply other threads:[~2011-06-09 9:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 8:56 Rainer Orth
2011-04-05 9:47 ` Richard Guenther
2011-04-05 17:42 ` Mike Stump
2011-04-05 18:11 ` Rainer Orth
2011-06-09 7:33 ` Rainer Orth
2011-06-09 9:51 ` Richard Guenther
2011-06-09 10:00 ` Jan Hubicka [this message]
2011-06-09 18:52 ` Mike Stump
2011-04-05 17:44 ` Mike Stump
2011-04-05 18:21 ` Rainer Orth
2011-04-19 18:31 ` Rainer Orth
2011-04-20 8:26 ` Mike Stump
2011-04-21 13:04 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609095436.GA10734@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=rguenther@suse.de \
--cc=richard.guenther@gmail.com \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).