From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4813 invoked by alias); 9 Jun 2011 18:50:14 -0000 Received: (qmail 4805 invoked by uid 22791); 9 Jun 2011 18:50:13 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Jun 2011 18:49:59 +0000 Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id p59InwFI022381; Thu, 9 Jun 2011 11:49:58 -0700 Received: from topo.tor.corp.google.com (topo.tor.corp.google.com [172.29.41.2]) by hpaq14.eem.corp.google.com with ESMTP id p59IntDM001075; Thu, 9 Jun 2011 11:49:56 -0700 Received: by topo.tor.corp.google.com (Postfix, from userid 54752) id 794601DA1CD; Thu, 9 Jun 2011 14:49:55 -0400 (EDT) To: reply@codereview.appspotmail.com, gchare@google.com, crowl@google.com, gcc-patches@gcc.gnu.org Subject: [pph] Do not emit PCH if generating PPH (issue4591061) Message-Id: <20110609184955.794601DA1CD@topo.tor.corp.google.com> Date: Thu, 09 Jun 2011 18:55:00 -0000 From: dnovillo@google.com (Diego Novillo) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00757.txt.bz2 We were trying to generate PCH and PPH information at the same time. We never noticed because PPH is generated after PCH, so we were just clobbering over the previous dump. Found it by accident while debugging a GC ICE. This should make testing slightly faster. Committed to the branch. * lang-specs.h (@c++-header): Do not emit PCH if any -fpph flag is present. diff --git a/gcc/cp/lang-specs.h b/gcc/cp/lang-specs.h index a73aba3..9943446 100644 --- a/gcc/cp/lang-specs.h +++ b/gcc/cp/lang-specs.h @@ -48,8 +48,8 @@ along with GCC; see the file COPYING3. If not see cc1plus %{save-temps*|no-integrated-cpp:-fpreprocessed %{save-temps*:%b.ii} %{!save-temps*:%g.ii}}\ %{!save-temps*:%{!no-integrated-cpp:%(cpp_unique_options)}}\ %(cc1_options) %2\ - %{!fsyntax-only:%{!fdump-ada-spec*:-o %g.s %{!o*:--output-pch=%i.gch}\ - %W{o*:--output-pch=%*}}%V}}}}", + %{!fsyntax-only:%{!fpph*:%{!fdump-ada-spec*:-o %g.s %{!o*:--output-pch=%i.gch}\ + %W{o*:--output-pch=%*}}}%V}}}}", CPLUSPLUS_CPP_SPEC, 0, 0}, {"@c++", "%{E|M|MM:cc1plus -E %(cpp_options) %2 %(cpp_debug_options)}\ -- This patch is available for review at http://codereview.appspot.com/4591061