public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: dnovillo@google.com (Diego Novillo)
To: reply@codereview.appspotmail.com, lxo@redhat.com,
	crowl@google.com,        gchare@google.com,
	gcc-patches@gcc.gnu.org
Subject: [pph contrib] Add support for multiple spawn patterns in repro_fail (issue4571061)
Date: Fri, 10 Jun 2011 23:52:00 -0000	[thread overview]
Message-ID: <20110610225101.D18D71DA1CD@topo.tor.corp.google.com> (raw)


So I had to go back to grep|sed instead of just sed because I want
to use extended regexps supported by grep -E.  In pph this is useful
so that you can specify patterns that match both the writing and the
reading of the PPH files.

I'm thinking that this script is better written in python, but that
may make it less generic and I don't know whether we accept python in
gcc/contrib.  Alex?

Committed to pph branch.


Diego.


	* repro_fail: Add support for patterns matching multiple spawns.

diff --git a/contrib/repro_fail b/contrib/repro_fail
index d5bce04..8100456 100755
--- a/contrib/repro_fail
+++ b/contrib/repro_fail
@@ -1,6 +1,6 @@
-#!/bin/bash
+#!/bin/bash -eu
 #
-# Script to reproduce a test failure from a dejagnu .log file
+# Script to reproduce a test failure from a dejagnu .log file.
 #
 # Contributed by Diego Novillo <dnovillo@google.com>
 #
@@ -23,6 +23,13 @@
 # the Free Software Foundation, 51 Franklin Street, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 
+# This script will search a line starting with 'spawn' that includes the
+# pattern you are looking for (typically a source file name).
+#
+# Once it finds that pattern, it re-executes the whole command
+# in the spawn line.  If the pattern matches more than one spawn
+# command, it asks which one you want.
+
 if [ $# -lt 2 ] ; then
     echo "usage: $0 pattern file.log [additional-args]"
     echo
@@ -32,18 +39,44 @@ if [ $# -lt 2 ] ; then
     exit 1
 fi
 
-set -e
-pattern=$1
-logf=$2
+pattern="$1"
+logf="$2"
 shift 2
-args="$@"
-line=$(grep "^spawn .*$pattern" $logf | sed -e "s:^spawn ::")
 
-if [ "$line" = "" ] ; then
-    echo "Could not find a spawn command for pattern $1"
+# Find the commands in LOGF that reference PATTERN.
+lines=$(grep -E "^spawn .*$pattern" $logf | sed -e 's/^spawn //')
+if [ -z "$lines" ] ; then
+    echo "Could not find a spawn command for pattern $pattern"
     exit 1
 fi
 
-set -x +e
-$line $args
-exit $?
+# Collect all the command lines into the COMMANDS array.
+old_IFS="$IFS"
+IFS="\r"
+num_lines=0
+for line in $lines ; do
+    num_lines=$[$num_lines + 1]
+    echo "[$num_lines] $line"
+    commands[$num_lines]=$line
+done
+
+# If we found more than one line for PATTERN, ask which one we should run.
+cmds_to_run='0'
+if [ $num_lines -gt 1 ] ; then
+    echo
+    echo
+    echo -n "Enter the list of commands to run or '0' to run them all: "
+    read cmds_to_run
+fi
+if [ "$cmds_to_run" = "0" ] ; then
+    cmds_to_run=$(seq 1 $num_lines)
+fi
+IFS="$old_IFS"
+
+# Finally, execute all the commands we were told to execute.
+for cmd_num in $cmds_to_run ; do
+    cmd=${commands[$cmd_num]}
+    set -x +e
+    $cmd "$@"
+    set +x -e
+done

--
This patch is available for review at http://codereview.appspot.com/4571061

             reply	other threads:[~2011-06-10 22:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10 23:52 Diego Novillo [this message]
2011-06-21 18:50 ` Alexandre Oliva
2011-06-24 13:30   ` Diego Novillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110610225101.D18D71DA1CD@topo.tor.corp.google.com \
    --to=dnovillo@google.com \
    --cc=crowl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gchare@google.com \
    --cc=lxo@redhat.com \
    --cc=reply@codereview.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).