From: Jan Hubicka <hubicka@ucw.cz>
To: gcc-patches@gcc.gnu.org
Subject: Cgraph alias reorg 16/14 (fix latent bug in ipa.c)
Date: Sat, 11 Jun 2011 14:36:00 -0000 [thread overview]
Message-ID: <20110611141917.GA3871@kam.mff.cuni.cz> (raw)
Hi,
there is typo in cgraph_comdat_can_be_unshared_p that causes us to sometimes diverge in visibility
of the single comdat group that leads to undefined symbols in Mozlla.
Fixed thus.
Bootstrapped/regtested x86_64-linux, comitted.
Index: ChangeLog
===================================================================
--- ChangeLog (revision 174952)
+++ ChangeLog (working copy)
@@ -1,5 +1,9 @@
2011-06-11 Jan Hubicka <jh@suse.cz>
+ * ipa.c (cgraph_comdat_can_be_unshared_p): Fix pasto.
+
+2011-06-11 Jan Hubicka <jh@suse.cz>
+
* lto-symtab.c (lto_cgraph_replace_node): Kill same body alias code.
(lto_symtab_resolve_can_prevail_p): Likewise.
(lto_symtab_merge_cgraph_nodes): Update merging of aliases.
Index: ipa.c
===================================================================
--- ipa.c (revision 174952)
+++ ipa.c (working copy)
@@ -571,7 +571,7 @@ cgraph_comdat_can_be_unshared_p (struct
address taken. */
for (next = node->same_comdat_group;
next != node; next = next->same_comdat_group)
- if (cgraph_address_taken_from_non_vtable_p (node)
+ if (cgraph_address_taken_from_non_vtable_p (next)
&& !DECL_VIRTUAL_P (next->decl))
return false;
}
reply other threads:[~2011-06-11 14:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110611141917.GA3871@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).