* [PATCH] Only run pr48377.c testcase on i?86/x86_64
@ 2011-06-03 13:59 Jakub Jelinek
2011-06-06 9:32 ` Richard Guenther
2011-06-14 9:37 ` Eric Botcazou
0 siblings, 2 replies; 8+ messages in thread
From: Jakub Jelinek @ 2011-06-03 13:59 UTC (permalink / raw)
To: gcc-patches
Hi!
This limits this testcase to i?86/x86_64 (moving to gcc.target/ would
be harder because it relies on all the weirdo vectorization options to be
passed), because apparently on strict alignment targets we don't handle
aligned (1) non-aggregates correctly. Or should it be instead xfailed
just on selected strict-aligned targets?
2011-06-03 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/48377
* gcc.dg/vect/pr48377.c: Only run the test to i?86/x86_64.
--- gcc/testsuite/gcc.dg/vect/pr48377.c.jj 2011-05-02 18:39:10.000000000 +0200
+++ gcc/testsuite/gcc.dg/vect/pr48377.c 2011-06-03 13:19:53.000000000 +0200
@@ -1,4 +1,5 @@
/* PR tree-optimization/48377 */
+/* { dg-do run { target i?86-*-* x86_64-*-* } } */
typedef unsigned int U __attribute__((__aligned__ (1), __may_alias__));
Jakub
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Only run pr48377.c testcase on i?86/x86_64
2011-06-03 13:59 [PATCH] Only run pr48377.c testcase on i?86/x86_64 Jakub Jelinek
@ 2011-06-06 9:32 ` Richard Guenther
2011-06-06 9:46 ` Rainer Orth
2011-06-14 9:37 ` Eric Botcazou
1 sibling, 1 reply; 8+ messages in thread
From: Richard Guenther @ 2011-06-06 9:32 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
On Fri, Jun 3, 2011 at 3:59 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> This limits this testcase to i?86/x86_64 (moving to gcc.target/ would
> be harder because it relies on all the weirdo vectorization options to be
> passed), because apparently on strict alignment targets we don't handle
> aligned (1) non-aggregates correctly. Or should it be instead xfailed
> just on selected strict-aligned targets?
This has come up in the past, I think we should have an
strict-align target capability in our dejagnu harness (possibly
just white-listing all patterns we know). So we can
dg-skip this test for strict-align ones. Would you mind implementing
that?
Thanks,
Richard.
> 2011-06-03 Jakub Jelinek <jakub@redhat.com>
>
> PR tree-optimization/48377
> * gcc.dg/vect/pr48377.c: Only run the test to i?86/x86_64.
>
> --- gcc/testsuite/gcc.dg/vect/pr48377.c.jj 2011-05-02 18:39:10.000000000 +0200
> +++ gcc/testsuite/gcc.dg/vect/pr48377.c 2011-06-03 13:19:53.000000000 +0200
> @@ -1,4 +1,5 @@
> /* PR tree-optimization/48377 */
> +/* { dg-do run { target i?86-*-* x86_64-*-* } } */
>
> typedef unsigned int U __attribute__((__aligned__ (1), __may_alias__));
>
>
> Jakub
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Only run pr48377.c testcase on i?86/x86_64
2011-06-06 9:32 ` Richard Guenther
@ 2011-06-06 9:46 ` Rainer Orth
0 siblings, 0 replies; 8+ messages in thread
From: Rainer Orth @ 2011-06-06 9:46 UTC (permalink / raw)
To: Richard Guenther; +Cc: Jakub Jelinek, gcc-patches
Richard Guenther <richard.guenther@gmail.com> writes:
> On Fri, Jun 3, 2011 at 3:59 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> Hi!
>>
>> This limits this testcase to i?86/x86_64 (moving to gcc.target/ would
>> be harder because it relies on all the weirdo vectorization options to be
>> passed), because apparently on strict alignment targets we don't handle
>> aligned (1) non-aggregates correctly. Or should it be instead xfailed
>> just on selected strict-aligned targets?
>
> This has come up in the past, I think we should have an
> strict-align target capability in our dejagnu harness (possibly
> just white-listing all patterns we know). So we can
> dg-skip this test for strict-align ones. Would you mind implementing
> that?
That list is quite long, though: there are currently 28 instances of
#define STRICT_ALIGNMENT 1
in gcc/config, with a couple of others being variable. Wouldn't it be
better to have a proper testcase instead?
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Only run pr48377.c testcase on i?86/x86_64
2011-06-03 13:59 [PATCH] Only run pr48377.c testcase on i?86/x86_64 Jakub Jelinek
2011-06-06 9:32 ` Richard Guenther
@ 2011-06-14 9:37 ` Eric Botcazou
2011-06-14 9:49 ` Jakub Jelinek
1 sibling, 1 reply; 8+ messages in thread
From: Eric Botcazou @ 2011-06-14 9:37 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
> This limits this testcase to i?86/x86_64 (moving to gcc.target/ would
> be harder because it relies on all the weirdo vectorization options to be
> passed), because apparently on strict alignment targets we don't handle
> aligned (1) non-aggregates correctly. Or should it be instead xfailed
> just on selected strict-aligned targets?
The 6.4.1 release is approaching so please install the patch for now. TIA.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Only run pr48377.c testcase on i?86/x86_64
2011-06-14 9:37 ` Eric Botcazou
@ 2011-06-14 9:49 ` Jakub Jelinek
2011-06-14 15:00 ` Eric Botcazou
0 siblings, 1 reply; 8+ messages in thread
From: Jakub Jelinek @ 2011-06-14 9:49 UTC (permalink / raw)
To: Eric Botcazou; +Cc: gcc-patches, Steve Ellcey
On Tue, Jun 14, 2011 at 11:10:13AM +0200, Eric Botcazou wrote:
> > This limits this testcase to i?86/x86_64 (moving to gcc.target/ would
> > be harder because it relies on all the weirdo vectorization options to be
> > passed), because apparently on strict alignment targets we don't handle
> > aligned (1) non-aggregates correctly. Or should it be instead xfailed
> > just on selected strict-aligned targets?
>
> The 6.4.1 release is approaching so please install the patch for now. TIA.
Well, Steve has a patch for non_strict_align effective_target
in http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00673.html
(with s/strict_align/non_strict_align/g ), I was hoping it would be reviewed
and I'd just adjust the testcase to use it as well.
Jakub
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Only run pr48377.c testcase on i?86/x86_64
2011-06-14 9:49 ` Jakub Jelinek
@ 2011-06-14 15:00 ` Eric Botcazou
2011-06-14 15:57 ` Jakub Jelinek
0 siblings, 1 reply; 8+ messages in thread
From: Eric Botcazou @ 2011-06-14 15:00 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches, Steve Ellcey
> Well, Steve has a patch for non_strict_align effective_target
> in http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00673.html
> (with s/strict_align/non_strict_align/g ), I was hoping it would be
> reviewed and I'd just adjust the testcase to use it as well.
Would it be applied to the 4.6 branch as well? If no, I think you should apply
your patch to trunk and 4.6 branch and let Steve adjust it on trunk later.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Only run pr48377.c testcase on i?86/x86_64
2011-06-14 15:00 ` Eric Botcazou
@ 2011-06-14 15:57 ` Jakub Jelinek
2011-06-25 23:41 ` Mike Stump
0 siblings, 1 reply; 8+ messages in thread
From: Jakub Jelinek @ 2011-06-14 15:57 UTC (permalink / raw)
To: Eric Botcazou, Mike Stump; +Cc: gcc-patches, Steve Ellcey
On Tue, Jun 14, 2011 at 04:52:18PM +0200, Eric Botcazou wrote:
> > Well, Steve has a patch for non_strict_align effective_target
> > in http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00673.html
> > (with s/strict_align/non_strict_align/g ), I was hoping it would be
> > reviewed and I'd just adjust the testcase to use it as well.
>
> Would it be applied to the 4.6 branch as well? If no, I think you should apply
> your patch to trunk and 4.6 branch and let Steve adjust it on trunk later.
I'd say it should be applied there as well.
Here is what I've just bootstrapped/regtested, Steve's patch with that
s/strict_align/non_strict_align/g plus a smallish change on top of that.
Mike, is this ok for trunk/4.6?
2011-06-14 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/48377
* gcc.dg/vect/pr48377.c: Add dg-require-effective-target
non_strict_align.
2011-06-14 Steve Ellcey <sje@cup.hp.com>
PR middle-end/49191
* lib/target-supports.exp (check_effective_target_non_strict_align):
New.
* gcc.dg/memcpy-3.c: Add dg-require-effective-target non_strict_align.
--- gcc/testsuite/lib/target-supports.exp (revision 174336)
+++ gcc/testsuite/lib/target-supports.exp (working copy)
@@ -3901,3 +3901,11 @@
return 1
}
+proc check_effective_target_non_strict_align {} {
+ return [check_no_compiler_messages non_strict_align assembly {
+ char *y;
+ typedef char __attribute__ ((__aligned__(__BIGGEST_ALIGNMENT__))) c;
+ c *z;
+ void foo(void) { z = (c *) y; }
+ } "-Wcast-align"]
+}
--- gcc/testsuite/gcc.dg/memcpy-3.c (revision 174336)
+++ gcc/testsuite/gcc.dg/memcpy-3.c (working copy)
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-options "-O -fdump-tree-optimized" } */
+/* { dg-require-effective-target non_strict_align } */
int get_int(const void *p)
{
--- gcc/testsuite/gcc.dg/vect/pr48377.c.jj 2011-05-02 18:39:10.000000000 +0200
+++ gcc/testsuite/gcc.dg/vect/pr48377.c 2011-06-03 13:19:53.000000000 +0200
@@ -1,4 +1,5 @@
/* PR tree-optimization/48377 */
+/* { dg-require-effective-target non_strict_align } */
typedef unsigned int U __attribute__((__aligned__ (1), __may_alias__));
Jakub
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Only run pr48377.c testcase on i?86/x86_64
2011-06-14 15:57 ` Jakub Jelinek
@ 2011-06-25 23:41 ` Mike Stump
0 siblings, 0 replies; 8+ messages in thread
From: Mike Stump @ 2011-06-25 23:41 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Eric Botcazou, gcc-patches, Steve Ellcey
On Jun 14, 2011, at 8:53 AM, Jakub Jelinek wrote:
> On Tue, Jun 14, 2011 at 04:52:18PM +0200, Eric Botcazou wrote:
>>> Well, Steve has a patch for non_strict_align effective_target
>>> in http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00673.html
>>> (with s/strict_align/non_strict_align/g ), I was hoping it would be
>>> reviewed and I'd just adjust the testcase to use it as well.
>>
>> Would it be applied to the 4.6 branch as well? If no, I think you should apply
>> your patch to trunk and 4.6 branch and let Steve adjust it on trunk later.
>
> I'd say it should be applied there as well.
>
> Here is what I've just bootstrapped/regtested, Steve's patch with that
> s/strict_align/non_strict_align/g plus a smallish change on top of that.
>
> Mike, is this ok for trunk/4.6?
Ok.
> 2011-06-14 Jakub Jelinek <jakub@redhat.com>
>
> PR tree-optimization/48377
> * gcc.dg/vect/pr48377.c: Add dg-require-effective-target
> non_strict_align.
>
> 2011-06-14 Steve Ellcey <sje@cup.hp.com>
>
> PR middle-end/49191
> * lib/target-supports.exp (check_effective_target_non_strict_align):
> New.
> * gcc.dg/memcpy-3.c: Add dg-require-effective-target non_strict_align.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-06-25 23:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-03 13:59 [PATCH] Only run pr48377.c testcase on i?86/x86_64 Jakub Jelinek
2011-06-06 9:32 ` Richard Guenther
2011-06-06 9:46 ` Rainer Orth
2011-06-14 9:37 ` Eric Botcazou
2011-06-14 9:49 ` Jakub Jelinek
2011-06-14 15:00 ` Eric Botcazou
2011-06-14 15:57 ` Jakub Jelinek
2011-06-25 23:41 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).