From: Zdenek Dvorak <rakdver@kam.mff.cuni.cz>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Tom de Vries <vries@codesourcery.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH PR45098] Disallow NULL pointer in pointer arithmetic
Date: Thu, 16 Jun 2011 15:54:00 -0000 [thread overview]
Message-ID: <20110616154240.GA15905@kam.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTim_930jBZ6csPsrBb04mof6gfcOgQ@mail.gmail.com>
> >> diff -u gcc/tree-ssa-loop-niter.c (working copy) gcc/tree-ssa-loop-niter.c (working copy)
> >> --- gcc/tree-ssa-loop-niter.c (working copy)
> >> +++ gcc/tree-ssa-loop-niter.c (working copy)
> >> @@ -2875,6 +2875,16 @@
> >> Â Â low = lower_bound_in_type (type, type);
> >> Â Â high = upper_bound_in_type (type, type);
> >>
> >> + Â /* In C, pointer arithmetic p + 1 cannot use a NULL pointer, and p - 1 cannot
> >> + Â Â produce a NULL pointer. Â The contrary would mean NULL points to an object,
> >> + Â Â while NULL is supposed to compare unequal with the address of all objects.
> >> + Â Â Furthermore, p + 1 cannot produce a NULL pointer and p - 1 cannot use a
> >> + Â Â NULL pointer since that would mean wrapping, which we assume here not to
> >> + Â Â happen. Â So, we can exclude NULL from the valid range of pointer
> >> + Â Â arithmetic. Â */
> >> + Â if (int_cst_value (low) == 0)
> >> + Â Â low = build_int_cstu (TREE_TYPE (low), TYPE_ALIGN_UNIT (TREE_TYPE (type)));
> >> +
> >> Â Â record_nonwrapping_iv (loop, base, step, stmt, low, high, false, true);
> >> Â }
> >
> > OK,
>
> I think this is only valid for !flag_delete_null_pointer_checks, on
> architectures where that isn't the default we have to assume that
> NULL may point to an object.
agreed. Thanks for the correction.
Zdenek
next prev parent reply other threads:[~2011-06-16 15:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 6:42 Tom de Vries
2011-06-16 6:51 ` Tom de Vries
2011-06-16 7:34 ` Zdenek Dvorak
2011-06-16 12:22 ` Tom de Vries
2011-06-16 15:33 ` Zdenek Dvorak
2011-06-16 15:42 ` Richard Guenther
2011-06-16 15:54 ` Zdenek Dvorak [this message]
2011-06-16 18:10 ` Tom de Vries
2011-06-16 22:03 ` Jeff Law
2011-06-17 10:44 ` Tom de Vries
2011-06-17 10:56 ` Richard Guenther
2011-06-17 10:57 ` Zdenek Dvorak
2011-06-17 11:13 ` Richard Guenther
2011-06-17 11:22 ` Zdenek Dvorak
2011-06-17 13:01 ` Richard Guenther
2011-06-17 14:57 ` Zdenek Dvorak
2011-06-17 18:24 ` Jeff Law
2011-06-20 11:06 ` Richard Guenther
2011-06-20 12:26 ` Zdenek Dvorak
2011-06-20 12:41 ` Zdenek Dvorak
2011-06-20 13:29 ` Richard Guenther
2011-06-20 13:35 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616154240.GA15905@kam.mff.cuni.cz \
--to=rakdver@kam.mff.cuni.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=vries@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).