public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jack Howarth <howarth@bromo.med.uc.edu>
To: Mike Stump <mikestump@comcast.net>
Cc: gcc-patches@gcc.gnu.org, iains@gcc.gnu.org
Subject: Re: [PATCH][Revised] Pass -no_pie on SYSTEMSPEC for darwin11
Date: Sat, 18 Jun 2011 15:33:00 -0000	[thread overview]
Message-ID: <20110618152758.GA963@bromo.med.uc.edu> (raw)
In-Reply-To: <8035A572-9078-46F4-9172-8CB269E1E854@comcast.net>

On Sat, Jun 18, 2011 at 08:11:43AM -0700, Mike Stump wrote:
> On Jun 17, 2011, at 7:49 PM, Jack Howarth wrote:
> >  The gcj compiler needs to pass -no_pie for linkage on darwin11 due to the new -pie
> > default of the linker. The attached patch accomplishes this by passing -no_pie on SYSTEMSPEC
> > for *-*-darwin[12]*. Since Darwin10 supports -no_pie in its linker, I included it in the
> > triplet match to simplify the syntax. Bootstrap and tested on x86_64-apple-darwin11.
> > Okay for gcc trunk with PR added to comment as requested?
> >               Jack
> > ps This change also works for gcc-4_6-branch in concert with a backport of
> > r175089 and r175108.
> > 
> > 2011-06-17  Jack Howarth <howarth@bromo.med.uc.edu>
> > 
> > 	PR target/49461
> > 	* libjava/configure.ac (SYSTEMSPEC): Pass -no_pie for darwin11.
> > 	* libjava/configure: Regenerate.
> 
> Checked in r175182, with one additional comment.  We still welcome tracking down what exactly doesn't work and a bug report and fix for that, until then, I think life is too short to have java be broken for too long.
> 

Mike,
   Also note Ian's comments on -fPIE/-pie in http://gcc.gnu.org/ml/gcc/2011-06/msg00215.html.
             Jack

> 2011-06-17  Jack Howarth <howarth@bromo.med.uc.edu>
> 
> 	PR target/49461
> 	* libjava/configure.ac (SYSTEMSPEC): Pass -no_pie for darwin11.
> 	* libjava/configure: Regenerate.
> 
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 175181)
> +++ configure.ac	(revision 175182)
> @@ -898,9 +898,14 @@ case "${host}" in
>          SYSTEMSPEC="-lunicows $SYSTEMSPEC"
>        fi
>      ;;
> -    *-*-darwin[[912]]*)
> +    *-*-darwin9*)
>        SYSTEMSPEC="%{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}"
>      ;;
> +    *-*-darwin[[12]]*)
> +      # Something is incompatible with pie, would be nice to fix it and
> +      # remove -no_pie.  PR49461
> +      SYSTEMSPEC="-no_pie %{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}"
> +    ;;
>      *)
>        SYSTEMSPEC=
>      ;;

  reply	other threads:[~2011-06-18 15:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-18  5:52 Jack Howarth
2011-06-18 14:53 ` Mike Stump
2011-06-18 19:02   ` Jack Howarth
2011-06-18 15:28 ` Mike Stump
2011-06-18 15:32 ` Mike Stump
2011-06-18 15:33   ` Jack Howarth [this message]
2011-06-19 18:20   ` Mike Stump
2011-06-19 20:18     ` Jack Howarth
2011-06-19 23:20       ` Mike Stump
2011-06-19 23:33         ` Jack Howarth
     [not found]           ` <47DFC4C2-9E8E-40BD-BA97-2314A8263A68@comcast.net>
     [not found]             ` <20110619235544.GA32119@bromo.med.uc.edu>
2011-06-30 16:40               ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110618152758.GA963@bromo.med.uc.edu \
    --to=howarth@bromo.med.uc.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iains@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).