From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32218 invoked by alias); 18 Jun 2011 15:28:17 -0000 Received: (qmail 32203 invoked by uid 22791); 18 Jun 2011 15:28:16 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_GC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sat, 18 Jun 2011 15:28:00 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id 62511B005C; Sat, 18 Jun 2011 11:27:59 -0400 (EDT) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id p5IFRxpj000974; Sat, 18 Jun 2011 11:27:59 -0400 Date: Sat, 18 Jun 2011 15:33:00 -0000 From: Jack Howarth To: Mike Stump Cc: gcc-patches@gcc.gnu.org, iains@gcc.gnu.org Subject: Re: [PATCH][Revised] Pass -no_pie on SYSTEMSPEC for darwin11 Message-ID: <20110618152758.GA963@bromo.med.uc.edu> References: <20110618024913.GA29537@bromo.med.uc.edu> <8035A572-9078-46F4-9172-8CB269E1E854@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8035A572-9078-46F4-9172-8CB269E1E854@comcast.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01397.txt.bz2 On Sat, Jun 18, 2011 at 08:11:43AM -0700, Mike Stump wrote: > On Jun 17, 2011, at 7:49 PM, Jack Howarth wrote: > > The gcj compiler needs to pass -no_pie for linkage on darwin11 due to the new -pie > > default of the linker. The attached patch accomplishes this by passing -no_pie on SYSTEMSPEC > > for *-*-darwin[12]*. Since Darwin10 supports -no_pie in its linker, I included it in the > > triplet match to simplify the syntax. Bootstrap and tested on x86_64-apple-darwin11. > > Okay for gcc trunk with PR added to comment as requested? > > Jack > > ps This change also works for gcc-4_6-branch in concert with a backport of > > r175089 and r175108. > > > > 2011-06-17 Jack Howarth > > > > PR target/49461 > > * libjava/configure.ac (SYSTEMSPEC): Pass -no_pie for darwin11. > > * libjava/configure: Regenerate. > > Checked in r175182, with one additional comment. We still welcome tracking down what exactly doesn't work and a bug report and fix for that, until then, I think life is too short to have java be broken for too long. > Mike, Also note Ian's comments on -fPIE/-pie in http://gcc.gnu.org/ml/gcc/2011-06/msg00215.html. Jack > 2011-06-17 Jack Howarth > > PR target/49461 > * libjava/configure.ac (SYSTEMSPEC): Pass -no_pie for darwin11. > * libjava/configure: Regenerate. > > Index: configure.ac > =================================================================== > --- configure.ac (revision 175181) > +++ configure.ac (revision 175182) > @@ -898,9 +898,14 @@ case "${host}" in > SYSTEMSPEC="-lunicows $SYSTEMSPEC" > fi > ;; > - *-*-darwin[[912]]*) > + *-*-darwin9*) > SYSTEMSPEC="%{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" > ;; > + *-*-darwin[[12]]*) > + # Something is incompatible with pie, would be nice to fix it and > + # remove -no_pie. PR49461 > + SYSTEMSPEC="-no_pie %{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" > + ;; > *) > SYSTEMSPEC= > ;;