From: Eric Botcazou <ebotcazou@adacore.com>
To: Richard Henderson <rth@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Dave Miller <davem@redhat.com>
Subject: Re: Converting Sparc to REG_CFA_* notes
Date: Mon, 20 Jun 2011 02:07:00 -0000 [thread overview]
Message-ID: <201106200137.12359.ebotcazou@adacore.com> (raw)
In-Reply-To: <4DFE840D.6020609@redhat.com>
> I've tested this via cross-compile and the unwind info is unchanged before
> and after. However, I'll hold off checking it in for the moment until it
> has had a chance to go through a true bootstrap cycle. Dave, might you
> have a moment to do that?
Note that you have SPARC/Linux machines in the Compile Farm.
Minor nits:
+ /* The return address (%i7) is saved in %o7. */
+ add_reg_note (insn, REG_CFA_REGISTER,
+ gen_rtx_SET (VOIDmode,
+ gen_rtx_REG (Pmode, 31),
+ gen_rtx_REG (Pmode, 15)));
We have RETURN_ADDR_REGNUM and INCOMING_RETURN_ADDR_REGNUM nowadays.
+ /* The CFA is %o6, the hard frame pointer. */
+ add_reg_note (insn, REG_CFA_DEF_CFA, hard_frame_pointer_rtx);
%o6 is %sp, the stack pointer. You want %fp (better than %i6 IMO).
--
Eric Botcazou
next prev parent reply other threads:[~2011-06-19 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 23:41 Richard Henderson
2011-06-20 2:07 ` Eric Botcazou [this message]
2011-06-20 3:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106200137.12359.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=davem@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).