From: gchare@google.com (Gabriel Charette)
To: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: [pph] Fix binding_level's names_size streaming (issue4634071)
Date: Thu, 23 Jun 2011 00:06:00 -0000 [thread overview]
Message-ID: <20110623000043.9F45D1C0DAE@gchare.mtv.corp.google.com> (raw)
Here is the patch removing names_size.
We found out it was write-only and that we could remove it.
I tested it with a full bootstrap build as well as a full regression test (make check-g++).
(actually one of the pph test fails, but that's because of a line number issue in where
we expect the ICE... I'll have to re-upload the patch as the script already submitted the files...)
2011-06-22 Gabriel Charette <gchare@google.com>
* gcc/cp/name-lookup.h (cp_binding_level): Removed unused
member names_size. Update all users.
diff --git a/gcc/cp/name-lookup.c b/gcc/cp/name-lookup.c
index 54977ce..297c57e 100644
--- a/gcc/cp/name-lookup.c
+++ b/gcc/cp/name-lookup.c
@@ -544,7 +544,6 @@ add_decl_to_level (tree decl, cxx_scope *b)
necessary. */
TREE_CHAIN (decl) = b->names;
b->names = decl;
- b->names_size++;
/* If appropriate, add decl to separate list of statics. We
include extern variables because they might turn out to be
diff --git a/gcc/cp/name-lookup.h b/gcc/cp/name-lookup.h
index 009b5d9..5f266eb 100644
--- a/gcc/cp/name-lookup.h
+++ b/gcc/cp/name-lookup.h
@@ -191,9 +191,6 @@ struct GTY(()) cp_binding_level {
are wrapped in TREE_LISTs; the TREE_VALUE is the OVERLOAD. */
tree names;
- /* Count of elements in names chain. */
- size_t names_size;
-
/* A chain of NAMESPACE_DECL nodes. */
tree namespaces;
diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
index 0e8c6bf..a535cab 100644
--- a/gcc/cp/pph-streamer-in.c
+++ b/gcc/cp/pph-streamer-in.c
@@ -442,7 +442,6 @@ pph_in_binding_level (pph_stream *stream)
ALLOC_AND_REGISTER (stream, ix, bl, ggc_alloc_cleared_cp_binding_level ());
bl->names = pph_in_chain (stream);
- bl->names_size = pph_in_uint (stream);
bl->namespaces = pph_in_chain (stream);
bl->static_decls = pph_in_tree_vec (stream);
diff --git a/gcc/cp/pph-streamer-out.c b/gcc/cp/pph-streamer-out.c
index f219cef..7a6c516 100644
--- a/gcc/cp/pph-streamer-out.c
+++ b/gcc/cp/pph-streamer-out.c
@@ -448,7 +448,6 @@ pph_out_binding_level (pph_stream *stream, struct cp_binding_level *bl,
return;
pph_out_chain_filtered (stream, bl->names, ref_p, NO_BUILTINS);
- pph_out_uint (stream, bl->names_size);
pph_out_chain_filtered (stream, bl->namespaces, ref_p, NO_BUILTINS);
pph_out_tree_vec (stream, bl->static_decls, ref_p);
--
This patch is available for review at http://codereview.appspot.com/4634071
next reply other threads:[~2011-06-23 0:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 0:06 Gabriel Charette [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-24 20:05 dnovillo
2011-06-23 0:17 Gabriel Charette
2011-06-23 2:20 ` Gabriel Charette
2011-06-23 4:55 ` Gabriel Dos Reis
2011-06-23 11:33 ` Diego Novillo
2011-06-24 18:29 ` Gabriel Charette
2011-06-21 1:39 Gabriel Charette
2011-06-22 18:36 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623000043.9F45D1C0DAE@gchare.mtv.corp.google.com \
--to=gchare@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).