public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode
Date: Fri, 24 Jun 2011 14:18:00 -0000	[thread overview]
Message-ID: <201106241607.51611.ebotcazou@adacore.com> (raw)
In-Reply-To: <BANLkTi=uNifksMKzwTyWT93Kv+ihFtiO4Q@mail.gmail.com>

> I compared x32 glibc built with the old x32 gcc against x32 glibc built
> with this patch and
>
> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00913.html
>
> reverted, the new glibc is little smaller:
>
> New:
>
> [hjl@gnu-33 build-x86_64-linux]$ size libc.so
>    text	   data	    bss	    dec	    hex	filename
> 1537648	  10076	  12944	1560668	 17d05c	libc.so
> [hjl@gnu-33 build-x86_64-linux]$
>
> Old:
>
> [hjl@gnu-33 build-x86_64-linux.old]$ size libc.so
>    text	   data	    bss	    dec	    hex	filename
> 1538968	  10076	  12944	1561988	 17d584	libc.so
> [hjl@gnu-33 build-x86_64-linux.old]$
>
> I looked at assembly codes.  The new one is better.
> I will check it in.

OK, but remove the equivalent code in num_sign_bit_copies1 then, otherwise 
someone in a couple of years from now will adapt it to nonzero_bits1 and we 
will be back to square one.

-- 
Eric Botcazou

  reply	other threads:[~2011-06-24 14:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 19:39 H.J. Lu
2011-06-23 14:08 ` H.J. Lu
2011-06-24 10:00 ` Eric Botcazou
2011-06-24 13:55   ` H.J. Lu
2011-06-24 14:18     ` Eric Botcazou [this message]
2011-06-24 14:38       ` H.J. Lu
2011-06-24 15:50         ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106241607.51611.ebotcazou@adacore.com \
    --to=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).