From: Jakub Jelinek <jakub@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix dead_debug_insert_before ICE (PR debug/49522)
Date: Tue, 05 Jul 2011 20:12:00 -0000 [thread overview]
Message-ID: <20110705200651.GG2687@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <201107051035.12061.ebotcazou@adacore.com>
On Tue, Jul 05, 2011 at 10:35:11AM +0200, Eric Botcazou wrote:
> > There are two kinds of changes we do on the debug insns without immediate
> > rescanning:
> > 1) reset the debug insn
> > 2) replace a reg use with DEBUG_EXPR of the same mode or
> > subreg of a larger DEBUG_EXPR with the same outer mode as the reg
> >
> > In the attached testcase on arm a debug insn is reset, because a multi-reg
> > register has been used there and as the debug insn location was that
> > multi-reg register before, it is now VOIDmode after the reset - (clobber
> > (const_int 0)).
>
> That can happen only in this case, right? Otherwise, for a single register,
> the debug insn would have been removed from debug->head already. If so, how
> simpler would it be to remove the other uses in dead_debug_reset instead?
So you prefer something like this (untested) instead?
Without the second loop I have no idea how to make it work in
dead_debug_reset, the other dead_debug_use referencing the same insn might
be earlier or later in the chain.
--- gcc/df-problems.c 2011-07-04 19:17:50.757435754 +0200
+++ gcc/df-problems.c 2011-07-05 22:04:19.817464710 +0200
@@ -3117,6 +3117,25 @@ dead_debug_reset (struct dead_debug *deb
else
tailp = &(*tailp)->next;
}
+
+ /* If any other dead_debug_use structs refer to the debug insns
+ that have been reset above, remove them too. */
+ if (debug->to_rescan != NULL)
+ {
+ tailp = &debug->head;
+ while ((cur = *tailp))
+ {
+ insn = DF_REF_INSN (cur->use);
+ if (bitmap_bit_p (debug->to_rescan, INSN_UID (insn))
+ && VAR_LOC_UNKNOWN_P (INSN_VAR_LOCATION_LOC (insn)))
+ {
+ *tailp = cur->next;
+ XDELETE (cur);
+ }
+ else
+ tailp = &(*tailp)->next;
+ }
+ }
}
/* Add USE to DEBUG. It must be a dead reference to UREGNO in a debug
Jakub
next prev parent reply other threads:[~2011-07-05 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 17:29 Jakub Jelinek
2011-07-05 8:51 ` Eric Botcazou
2011-07-05 20:12 ` Jakub Jelinek [this message]
2011-07-06 19:48 ` [PATCH] Fix dead_debug_insert_before ICE (PR debug/49522, take 2) Jakub Jelinek
2011-07-06 20:55 ` Eric Botcazou
2011-07-07 10:27 ` [PATCH] Fix dead_debug_insert_before ICE (PR debug/49522, take 3) Jakub Jelinek
2011-07-07 15:53 ` Eric Botcazou
2011-07-06 20:36 ` [PATCH] Fix dead_debug_insert_before ICE (PR debug/49522) Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705200651.GG2687@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).