public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Improve Solaris mudflap support (PR libmudflap/49550)
Date: Wed, 06 Jul 2011 16:58:00 -0000	[thread overview]
Message-ID: <20110706163641.GA25124@redhat.com> (raw)
In-Reply-To: <yddr563gzbf.fsf@manam.CeBiTec.Uni-Bielefeld.DE>

Hi, Rainer -

> >> >   If so, I'd rather do it by adding some MFWRAP_OS_SPEC to avoid
> >> >   having to duplicate the whole spec in the Solaris config
> >> >   headers.
> >
> > Why would solaris have to duplicate MFWRAP_SPEC if mmap64 is added to
> > the default gcc.c one?
> 
> I assumed that you wanted to keep the default generic, and meant to
> separate target specific additions from the generic part.

I don't have a strong opinion on this, but if you add mmap64 to the
default, there need be no target-specific additions for solaris, right?
So we can delay the decision to another day.

> [...]
> I could either commit the current version with the MFWRAP_SPEC addition
> and work from there, or wait until those failures are understood and
> fixed, too.

Committing now would be fine, assuming no regressions on a primary
platform.

- FChE

  reply	other threads:[~2011-07-06 16:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 17:37 Rainer Orth
2011-07-04 13:27 ` Rainer Orth
     [not found]   ` <20110706160706.GB24690@redhat.com>
2011-07-06 16:16     ` Rainer Orth
2011-07-06 16:58       ` Frank Ch. Eigler [this message]
2011-07-06 17:11         ` Rainer Orth
2011-07-07 10:10         ` Rainer Orth
2011-07-06 16:16 Frank Ch. Eigler
2011-07-07 12:36 Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110706163641.GA25124@redhat.com \
    --to=fche@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).