From: Eric Botcazou <ebotcazou@adacore.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix dead_debug_insert_before ICE (PR debug/49522)
Date: Wed, 06 Jul 2011 20:36:00 -0000 [thread overview]
Message-ID: <201107062231.45109.ebotcazou@adacore.com> (raw)
In-Reply-To: <20110705200651.GG2687@tyan-ft48-01.lab.bos.redhat.com>
> So you prefer something like this (untested) instead?
I think that, ideally, we should avoid leaving the dead_debug chain in the
semi-broken state that we currently have.
> Without the second loop I have no idea how to make it work in
> dead_debug_reset, the other dead_debug_use referencing the same insn might
> be earlier or later in the chain.
I guess I was somehow hoping that you could use one of the numerous DF links to
get to the other uses; probably not, in the end, indeed. But you can set a
flag in the first loop in order to decide whether to run the second loop.
But I don't really have a strong opinon so, if you think that the original
patch is good enough, fine with me. Maybe use gcc_checking_assert though.
--
Eric Botcazou
prev parent reply other threads:[~2011-07-06 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 17:29 Jakub Jelinek
2011-07-05 8:51 ` Eric Botcazou
2011-07-05 20:12 ` Jakub Jelinek
2011-07-06 19:48 ` [PATCH] Fix dead_debug_insert_before ICE (PR debug/49522, take 2) Jakub Jelinek
2011-07-06 20:55 ` Eric Botcazou
2011-07-07 10:27 ` [PATCH] Fix dead_debug_insert_before ICE (PR debug/49522, take 3) Jakub Jelinek
2011-07-07 15:53 ` Eric Botcazou
2011-07-06 20:36 ` Eric Botcazou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107062231.45109.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).