public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
	gcc-patches@gcc.gnu.org,        rguenther@suse.de,
	"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH, testsuite] Fix for PR49519, miscompiled 447.dealII in SPEC CPU 2006
Date: Thu, 07 Jul 2011 20:03:00 -0000	[thread overview]
Message-ID: <20110707195541.GS2687@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <201107072152.32206.ebotcazou@adacore.com>

On Thu, Jul 07, 2011 at 09:52:31PM +0200, Eric Botcazou wrote:
> OK, modulo a few nits:
> 
> +  /* If address come in register - we have no idea of its origin, so
> +     give up and conservatively return true */
> +  else if (GET_CODE (addr) == REG)
> 
> /* If the address comes in a register, we have no idea of its origin so
>    give up and conservatively return true.  */
> 
> Note the period-double-space-star-slash GNUism at the end.  Non-negotiable.

Also, please use REG_P (addr) instead of GET_CODE (addr) == REG.

	Jakub

  reply	other threads:[~2011-07-07 19:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-06 16:11 Kirill Yukhin
2011-07-06 19:43 ` Eric Botcazou
2011-07-07  8:56   ` Kirill Yukhin
2011-07-07 19:56     ` Eric Botcazou
2011-07-07 20:03       ` Jakub Jelinek [this message]
2011-07-08 10:33         ` Kirill Yukhin
2011-07-08 11:24           ` Eric Botcazou
2011-07-08 13:13             ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110707195541.GS2687@tyan-ft48-01.lab.bos.redhat.com \
    --to=jakub@redhat.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=kirill.yukhin@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).