From: Jakub Jelinek <jakub@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Jason Merrill <jason@redhat.com>,
Richard Henderson <rth@redhat.com>,
Jan Kratochvil <jkratoch@redhat.com>,
Roland McGrath <roland@redhat.com>,
Cary Coutant <ccoutant@google.com>,
Mark Wielaard <mjw@redhat.com>
Subject: Re: [RFC] More compact (100x) -g3 .debug_macinfo (take 2)
Date: Fri, 15 Jul 2011 19:21:00 -0000 [thread overview]
Message-ID: <20110715182707.GN2687@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <m3hb6nbeaz.fsf@fleche.redhat.com>
On Fri, Jul 15, 2011 at 12:15:48PM -0600, Tom Tromey wrote:
> >>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
>
> Jakub> The patch below implements that slight change, in particular the
> Jakub> "4" suffixes from the op names were dropped,
> Jakub> DW_MACINFO_GNU_*_indirect have DW_FORM_udata and DW_FORM_strp
> Jakub> arguments now (i.e. DWARF_OFFSET_SIZE large) and
> Jakub> DW_MACINFO_GNU_transparent_include has DW_FORM_sec_offset
> Jakub> argument (i.e. again 4 bytes long for 32-bit DWARF and 8 bytes
> Jakub> long for 64-bit DWARF). GCC assures that no merging will happen
> Jakub> between .debug_macinfo chunks with 32-bit and 64-bit DWARF by
> Jakub> adding the byte size in the comdat GROUP name. I think that's
> Jakub> cleaner than hardcoding 4 bytes and not optimizing anything on
> Jakub> MIPS.
>
> The .debug_macinfo section doesn't have any header describing its
> contents. How would a consumer know which offset size to use?
The same way as it knows how to interpret the second operands of
DW_MACINFO_start_file. They aren't meaningful without knowing what
.debug_line section they refer to. For .debug_line, you need to remember
DW_AT_stmt_list of the CU that refers to the .debug_macinfo section
through DW_AT_macro_info, and you'd remember whether the referencing
CU is 32-bit DWARF or 64-bit DWARF. And the producer would need to arange
that DW_MACINFO_GNU_transparent_include referenced chunks have the same
properties (i.e. same offset size, and, if they use DW_MACINFO_start_file,
also the same .debug_line).
Jakub
next prev parent reply other threads:[~2011-07-15 18:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 17:12 [RFC] More compact (100x) -g3 .debug_macinfo Jakub Jelinek
2011-07-13 19:59 ` Tom Tromey
2011-07-13 20:37 ` Jakub Jelinek
2011-07-18 15:42 ` Tom Tromey
2011-07-15 15:52 ` [RFC] More compact (100x) -g3 .debug_macinfo (take 2) Jakub Jelinek
2011-07-15 17:19 ` Richard Henderson
2011-07-15 21:18 ` [RFC] More compact (100x) -g3 .debug_macinfo (take 3) Jakub Jelinek
2011-07-18 15:09 ` Tom Tromey
2011-07-20 1:17 ` Richard Henderson
2011-07-21 11:38 ` [RFC] More compact (100x) -g3 .debug_gnu_macro (take 4) Jakub Jelinek
2011-07-21 17:25 ` Richard Henderson
2011-07-21 18:13 ` Jakub Jelinek
2011-07-22 13:49 ` [RFC] More compact (100x) -g3 .debug_gnu_macro (take 5) Jakub Jelinek
2011-07-22 15:34 ` Tom Tromey
2011-07-22 17:24 ` Richard Henderson
2011-07-22 20:33 ` [RFC] More compact (100x) -g3 .debug_gnu_macro (take 4) Michael Eager
2011-07-22 21:50 ` Richard Henderson
2011-07-22 21:51 ` Michael Eager
2011-07-22 22:10 ` Richard Henderson
2011-07-23 0:32 ` Michael Eager
2011-07-23 0:36 ` Richard Henderson
2011-07-26 7:34 ` Jason Merrill
2011-07-15 18:28 ` [RFC] More compact (100x) -g3 .debug_macinfo (take 2) Tom Tromey
2011-07-15 19:21 ` Jakub Jelinek [this message]
2011-07-15 19:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715182707.GN2687@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=ccoutant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=jkratoch@redhat.com \
--cc=mjw@redhat.com \
--cc=roland@redhat.com \
--cc=rth@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).