From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31734 invoked by alias); 16 Jul 2011 12:59:46 -0000 Received: (qmail 31714 invoked by uid 22791); 16 Jul 2011 12:59:45 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp22.services.sfr.fr (HELO smtp22.services.sfr.fr) (93.17.128.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Jul 2011 12:59:30 +0000 Received: from filter.sfr.fr (localhost [127.0.0.1]) by msfrf2212.sfr.fr (SMTP Server) with ESMTP id 39DB17000097; Sat, 16 Jul 2011 14:59:29 +0200 (CEST) Received: from gimli.local (104.15.72.86.rev.sfr.net [86.72.15.104]) by msfrf2212.sfr.fr (SMTP Server) with ESMTP id 11B65700008A; Sat, 16 Jul 2011 14:59:29 +0200 (CEST) X-SFR-UUID: 20110716125929726.11B65700008A@msfrf2212.sfr.fr From: Mikael Morin To: fortran@gcc.gnu.org Subject: Re: [Patch, Fortran] Support allocatable *scalar* coarrays Date: Sat, 16 Jul 2011 14:38:00 -0000 User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.5.5; amd64; ; ) Cc: Tobias Burnus , gcc patches References: <4E1A03E8.3050706@net-b.de> <4E1AAB00.2030104@net-b.de> In-Reply-To: <4E1AAB00.2030104@net-b.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201107161459.26836.mikael.morin@sfr.fr> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg01318.txt.bz2 On Monday 11 July 2011 09:49:20 Tobias Burnus wrote: > On 07/10/2011 09:56 PM, Tobias Burnus wrote: > > This patch implemented the trans*.c part of allocatable scalar > > coarrays; contrary to noncoarray allocatable scalars, they have > > cobounds and thus use an array descriptor. > > I found a test case (part of Reinhold Bader's fortran_tests), which gave > an ICE: Allocatable scalar coarrays with SAVE. > > I have fixed that (trans-decl.c) and added a test. > > > The attached patch was build and regtested on x86-64-linux. > > OK for the trunk? > > Tobias Hello, let me understand one thing about coarray scalars: despite their name, they are arrays, right? Then when you do in gfc_conv_array_ref: + if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (se->expr))) + se->expr = build_fold_indirect_ref (gfc_conv_array_data (se->expr)); [...] return; you are returning scalar[1] instead of scalar (== scalar[this_image()]) or scalar[whatever_image_selector], aren't you? Sorry for the delay; it seems that the more it goes, the more you are the only one who can maintain coarray stuff. :-( Mikael