public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [Melt] Fix foreach_edge_bb_precs
@ 2011-07-25  9:33 Romain Geissler
  2011-07-26  9:01 ` [GCC-MELT-95] " Pierre
  0 siblings, 1 reply; 3+ messages in thread
From: Romain Geissler @ 2011-07-25  9:33 UTC (permalink / raw)
  To: gcc-patches, gcc-melt

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

Hello,

This iteratoc won't work because of a little typo error (the previous
edge field is preDs and not preCs).
To avoid future errors, i apply the global /precs/preds/ change (and
thus the iterator is renamed).

Romain Geissler

[-- Attachment #2: Changelog --]
[-- Type: application/octet-stream, Size: 182 bytes --]

2011-07-25  Romain Geissler  <romain.geissler@gmail.com>

	* melt/xtramelt-ana-base.melt (foreach_edge_bb_precs): Rename for
	foreach_edge_bb_preds. Fix structure field access typo.

[-- Attachment #3: foreach_edge_bb_preds.diff --]
[-- Type: application/octet-stream, Size: 1680 bytes --]

Index: xtramelt-ana-base.melt
===================================================================
--- xtramelt-ana-base.melt	(revision 176623)
+++ xtramelt-ana-base.melt	(working copy)
@@ -2300,26 +2300,26 @@
 )
 
 ;;;;;;;;;;;;;;;; iterating on edges preceding a given basic_block
-(defciterator foreach_edge_bb_precs
+(defciterator foreach_edge_bb_preds
   (:basic_block bb)			;the input formal
-  eachedgebbprec			;the state symbol
+  eachedgebbpred			;the state symbol
   (:edge edg)				;the local formal
   ;;
   ;; before expansion
-  #{ /* $EACHEDGEBBPREC++ */		
+  #{ /* $EACHEDGEBBPRED++ */		
   if ($BB) {
-    edge_iterator $EACHEDGEBBPREC#_iter = {};
-    edge $EACHEDGEBBPREC#_edge = NULL;
-    FOR_EACH_EDGE($EACHEDGEBBPREC#_edge, $EACHEDGEBBPREC#_iter, ($BB)->precs) 
+    edge_iterator $EACHEDGEBBPRED#_iter = {};
+    edge $EACHEDGEBBPRED#_edge = NULL;
+    FOR_EACH_EDGE($EACHEDGEBBPRED#_edge, $EACHEDGEBBPRED#_iter, ($BB)->preds) 
       {
-        if (!$EACHEDGEBBPREC#_edge) continue;
-	$EDG = $EACHEDGEBBPREC#_edge;
+        if (!$EACHEDGEBBPRED#_edge) continue;
+	$EDG = $EACHEDGEBBPRED#_edge;
   }#
   ;;
   ;; after expansion 
-  #{ /* $EACHEDGEBBPREC-- */
-     }; /* end FOR_EACH_EDGE $EACHEDGEBBPREC */
-   } /* end if $EACHEDGEBBPREC */
+  #{ /* $EACHEDGEBBPRED-- */
+     }; /* end FOR_EACH_EDGE $EACHEDGEBBPRED */
+   } /* end if $EACHEDGEBBPRED */
    }#
 )
 
@@ -3448,7 +3448,7 @@ and discriminant $DIS, usually $DISCR_MI
  foreach_argument_of_gimple_call
  foreach_basicblock_succ_edge
  foreach_case_of_gimple_switch
- foreach_edge_bb_precs
+ foreach_edge_bb_preds
  foreach_edge_bb_succs
  foreach_field_in_record_type
  foreach_loop_exit_edges

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GCC-MELT-95] [Melt] Fix foreach_edge_bb_precs
  2011-07-25  9:33 [Melt] Fix foreach_edge_bb_precs Romain Geissler
@ 2011-07-26  9:01 ` Pierre
  2011-07-26  9:02   ` Basile Starynkevitch
  0 siblings, 1 reply; 3+ messages in thread
From: Pierre @ 2011-07-26  9:01 UTC (permalink / raw)
  To: gcc-melt; +Cc: Romain Geissler, gcc-patches

On 25/07/2011 10:46, Romain Geissler wrote:
> Hello,
>
> This iteratoc won't work because of a little typo error (the previous
> edge field is preDs and not preCs).
> To avoid future errors, i apply the global /precs/preds/ change (and
> thus the iterator is renamed).
>
> Romain Geissler
>

Hello,

I wrote the initial iterator and agree with your change. I guess Basile 
will commit it soon.

Pierre

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GCC-MELT-95] [Melt] Fix foreach_edge_bb_precs
  2011-07-26  9:01 ` [GCC-MELT-95] " Pierre
@ 2011-07-26  9:02   ` Basile Starynkevitch
  0 siblings, 0 replies; 3+ messages in thread
From: Basile Starynkevitch @ 2011-07-26  9:02 UTC (permalink / raw)
  To: Pierre; +Cc: gcc-melt, Romain Geissler, gcc-patches

On Tue, Jul 26, 2011 at 10:02:35AM +0200, Pierre wrote:
> On 25/07/2011 10:46, Romain Geissler wrote:
> >Hello,
> >
> >This iteratoc won't work because of a little typo error (the previous
> >edge field is preDs and not preCs).
> >To avoid future errors, i apply the global /precs/preds/ change (and
> >thus the iterator is renamed).
> >
> >Romain Geissler
> >
> 
> Hello,
> 
> I wrote the initial iterator and agree with your change. I guess
> Basile will commit it soon.

It is committed.



-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-26  8:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-25  9:33 [Melt] Fix foreach_edge_bb_precs Romain Geissler
2011-07-26  9:01 ` [GCC-MELT-95] " Pierre
2011-07-26  9:02   ` Basile Starynkevitch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).