From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: matz@suse.de (Michael Matz)
Cc: richard.guenther@gmail.com (Richard Guenther), gcc-patches@gcc.gnu.org
Subject: Re: Merge alignments from coalesced SSA pointers
Date: Tue, 26 Jul 2011 17:28:00 -0000 [thread overview]
Message-ID: <201107261656.p6QGu5wF029090@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1107261754270.25049@wotan.suse.de> from "Michael Matz" at Jul 26, 2011 05:56:16 PM
Michael Matz wrote:
> On Tue, 26 Jul 2011, Michael Matz wrote:
> > On Tue, 26 Jul 2011, Ulrich Weigand wrote:
> >
> > > > Well, REG_ATTRS->decl is again a decl, not an SSA name. I suppose
> > > > we'd need to pick a conservative REGNO_POINTER_ALIGN during
> > > > expansion of the SSA name partition - iterate over all of them in the
> > > > partition and pick the lowest alignment. Or even adjust the partitioning
> > > > to avoid losing alignment information that way.
> > >
> > > That would certainly be helpful.
> >
> > I'm working on a patch for that, stay tuned.
>
> Like so. Currently in regstrapping on x86_64-linux. Could you try if it
> helps spu?
Well, it does help SPU in the sense that the wrong code generation goes away.
However, it does so by setting REGNO_POINTER_ALIGN to the minimum of 8 just
about every time -- not sure what the impact on generated code quality is.
Maybe get_pointer_alignment should default to the type's alignment if
nothing more specific is known, at least on STRICT_ALIGNMENT targets?
Just like MEM_ALIGN defaults to the mode's alignment ...
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-07-26 16:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 8:24 [patch] Fix PR tree-optimization/49771 Ira Rosen
2011-07-19 9:49 ` Richard Guenther
2011-07-19 14:01 ` Ira Rosen
2011-07-19 14:03 ` Richard Guenther
2011-07-20 19:47 ` Ulrich Weigand
2011-07-21 12:54 ` Ira Rosen
2011-07-24 14:32 ` Ira Rosen
2011-07-24 18:46 ` Richard Guenther
2011-07-25 9:44 ` Ulrich Weigand
2011-07-25 10:08 ` Richard Guenther
2011-07-25 11:26 ` Ira Rosen
2011-07-25 11:41 ` Richard Guenther
2011-07-25 12:33 ` Ira Rosen
2011-07-25 13:01 ` Richard Guenther
2011-07-25 13:07 ` Richard Guenther
2011-07-25 13:47 ` Ulrich Weigand
2011-07-25 14:01 ` Richard Guenther
2011-07-25 14:10 ` Richard Guenther
2011-07-25 14:14 ` Richard Guenther
2011-07-25 14:54 ` Ulrich Weigand
2011-07-25 14:59 ` Richard Guenther
2011-07-25 16:12 ` Ulrich Weigand
2011-07-26 8:25 ` Richard Guenther
2011-07-26 8:59 ` Andrew Pinski
2011-07-26 14:23 ` Ulrich Weigand
2011-07-26 14:25 ` Michael Matz
2011-07-26 16:18 ` Merge alignments from coalesced SSA pointers Michael Matz
2011-07-26 17:23 ` Michael Matz
2011-08-08 16:34 ` Ulrich Weigand
2011-08-09 12:01 ` Michael Matz
2011-08-12 16:41 ` [rfa] Set alignment of pseudos via get_pointer_alignment Michael Matz
2011-08-12 22:53 ` Richard Guenther
2011-08-23 15:04 ` Michael Matz
2011-07-26 17:28 ` Ulrich Weigand [this message]
2011-07-27 9:13 ` Merge alignments from coalesced SSA pointers Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107261656.p6QGu5wF029090@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matz@suse.de \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).