public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, i386, testsuite] FMA intrinsics
Date: Wed, 24 Aug 2011 10:12:00 -0000	[thread overview]
Message-ID: <20110824085437.GO2687@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <CAFFGCRDywDPXcC5t=5T2-1ot0JFDJN59_iezcpi7ehYNmKD2Qg@mail.gmail.com>

On Wed, Aug 24, 2011 at 12:48:06PM +0400, Ilya Tocar wrote:
> Removed extra blank lines and pass tests through "indent".

You haven't:

@@ -25113,6 +25125,9 @@ static const struct builtin_description bdesc_multi_arg[] =                                                                
     "__builtin_ia32_vfmaddpd256", IX86_BUILTIN_VFMADDPD256,                                                                                       
     UNKNOWN, (int)MULTI_ARG_3_DF2 },                                                                                                              
                                                                                                                                                   
+                                                                                                                                                  
+                                                                                                                                                  
+                                                                                                                                                  
   { OPTION_MASK_ISA_FMA | OPTION_MASK_ISA_FMA4, CODE_FOR_fmaddsub_v4sf,                                                                           
     "__builtin_ia32_vfmaddsubps", IX86_BUILTIN_VFMADDSUBPS,                                                                                       
     UNKNOWN, (int)MULTI_ARG_3_SF },                                                                                                               

Also, why is fmaintrin.h including immintrin.h?  You can't include fmaintrin.h
directly and x86intrin.h has already included it before including fmaintrin.h.

	Jakub

  reply	other threads:[~2011-08-24  8:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20 11:23 Uros Bizjak
2011-08-22 17:32 ` Ilya Tocar
2011-08-22 20:41   ` Uros Bizjak
2011-08-23 14:55     ` Ilya Tocar
2011-08-23 15:33       ` Uros Bizjak
2011-08-24 10:06         ` Ilya Tocar
2011-08-24 10:12           ` Jakub Jelinek [this message]
2011-08-24 11:12             ` Ilya Tocar
2011-08-24 13:31               ` Uros Bizjak
2011-08-24 13:52                 ` Ilya Tocar
2011-08-24 22:00                   ` Uros Bizjak
2011-08-25 10:15                     ` Ilya Tocar
2011-08-25 10:46                       ` Uros Bizjak
2011-08-25 11:46                         ` Ilya Tocar
2011-08-25 11:46                           ` Jakub Jelinek
2011-08-25 11:49                             ` Ilya Tocar
2011-08-26 11:03                               ` Ilya Tocar
2011-08-26 14:07                                 ` H.J. Lu
2011-08-26 15:47                                   ` Ilya Tocar
2011-08-26 17:02                                     ` H.J. Lu
2011-08-26 17:06                                       ` H.J. Lu
2011-08-30 12:05                                         ` Ilya Tocar
2011-08-30 14:02                                           ` H.J. Lu
2011-08-30 14:10                                             ` Ilya Tocar
2011-08-30 14:32                                               ` Ilya Tocar
2011-08-30 15:25                                                 ` H.J. Lu
  -- strict thread matches above, loose matches on Subject: below --
2011-08-17 14:08 [PATCH, i386, testsuite]FMA intrinsics Ilya Tocar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110824085437.GO2687@tyan-ft48-01.lab.bos.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tocarip.intel@gmail.com \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).