From: Julian Brown <julian@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] ARM fixed-point support [5.5/6]: argument & return padding for libcalls
Date: Thu, 25 Aug 2011 07:35:00 -0000 [thread overview]
Message-ID: <20110824225150.648713fc@rex.config> (raw)
In-Reply-To: <20110824170455.195b5ead@rex.config>
On Wed, 24 Aug 2011 17:04:55 +0100
Julian Brown <julian@codesourcery.com> wrote:
> On Sun, 07 Aug 2011 18:47:57 +0100
> Richard Sandiford <rdsandiford@googlemail.com> wrote:
>
> > This patch caused several regressions on big-endian 64-bit MIPS
> > targets, which now try to shift single-precision floating-point
> > arguments to the top of an FPR. [...]
>
> Sorry for the breakage!
>
> > The patch below borrows the padding code from the main call
> > routines. It fixes the MIPS problems for me (tested on
> > mips64-linux-gnu), but I'm not set up for big-endian ARM testing.
> > From what I can tell, other targets' BLOCK_REG_PADDING definitions
> > already handle null types.
>
> I tested your patch very lightly on ARM, by running arm.exp &
> fixed-point.exp in both big & little-endian mode, and it looks fine.
> I'll set off a more-complete test run also, in case that's helpful...
The patch looks fine for big/little endian, gcc/g++/libstdc++, cross to
ARM EABI, btw.
Cheers,
Julian
next prev parent reply other threads:[~2011-08-24 21:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 17:51 Julian Brown
2011-06-30 13:51 ` Richard Earnshaw
2011-08-01 13:39 ` H.J. Lu
2011-08-01 13:52 ` H.J. Lu
2011-08-01 13:55 ` H.J. Lu
2011-08-01 14:24 ` Julian Brown
2011-08-07 18:50 ` Richard Sandiford
2011-08-18 21:37 ` Andrew Pinski
2011-08-24 18:09 ` Julian Brown
2011-08-25 7:35 ` Julian Brown [this message]
2011-08-25 18:46 ` RFA: PR 50061/50113: BLOCK_REG_PADDING " Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824225150.648713fc@rex.config \
--to=julian@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).