public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Julian Brown <julian@codesourcery.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gcc-patches@gcc.gnu.org, paul@codesourcery.com, rearnsha@arm.com,
	ramana.radhakrishnan@linaro.org (Ramana Radhakrishnan)
Subject: Re: [PATCH, ARM] Unaligned accesses for packed structures [1/2]
Date: Thu, 25 Aug 2011 18:19:00 -0000	[thread overview]
Message-ID: <20110825183121.2b08059b@rex.config> (raw)
In-Reply-To: <20110825164650.01ec842f@rex.config>

On Thu, 25 Aug 2011 16:46:50 +0100
Julian Brown <julian@codesourcery.com> wrote:

> So, OK to apply this version, assuming testing comes out OK? (And the
> followup patch [2/2], which remains unchanged?)

FWIW, all tests pass, apart from gcc.target/arm/volatile-bitfields-3.c,
which regresses. The output contains:

        ldrh    r0, [r3, #2]    @ unaligned

I believe that, to conform to the ARM EABI, that GCC must use an
(aligned) ldr in this case. Is that correct? If so, it looks like the
middle-end bitfield code does not take the setting of
-fstrict-volatile-bitfields into account.

Julian

  reply	other threads:[~2011-08-25 17:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 12:45 Julian Brown
2011-05-06 13:07 ` Richard Earnshaw
2011-05-09 17:50   ` Julian Brown
2011-05-10 14:03     ` Julian Brown
2011-05-26 17:06     ` Julian Brown
2011-07-04 11:44 ` Ulrich Weigand
2011-08-25 16:29   ` Julian Brown
2011-08-25 18:19     ` Julian Brown [this message]
2011-08-25 22:18       ` Ramana Radhakrishnan
2011-08-25 22:23         ` Joseph S. Myers
2011-08-26 17:37       ` Julian Brown
2011-09-08 17:35         ` Richard Earnshaw
2011-09-01 14:46     ` Ulrich Weigand
2011-09-22  6:47 ` Ye Joey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110825183121.2b08059b@rex.config \
    --to=julian@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul@codesourcery.com \
    --cc=ramana.radhakrishnan@linaro.org \
    --cc=rearnsha@arm.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).