From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16515 invoked by alias); 30 Aug 2011 09:07:42 -0000 Received: (qmail 16503 invoked by uid 22791); 30 Aug 2011 09:07:40 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 09:07:16 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7U97FfM007007 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 05:07:15 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7U97Eab032640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 30 Aug 2011 05:07:15 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p7U97E0I029178; Tue, 30 Aug 2011 11:07:14 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p7U97DDH029176; Tue, 30 Aug 2011 11:07:13 +0200 Date: Tue, 30 Aug 2011 09:29:00 -0000 From: Jakub Jelinek To: Uros Bizjak Cc: Richard Guenther , gcc-patches@gcc.gnu.org, uros@gcc.gnu.org, rth@redhat.com, artyom.shinkaroff@gmail.com Subject: Re: [PATCH] Change vcond to vcond Message-ID: <20110830090713.GG2687@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg02421.txt.bz2 On Tue, Aug 30, 2011 at 11:02:02AM +0200, Uros Bizjak wrote: > > Hmm.  But then I'd have to try emit an insn, right?  Currently > > the vectorizer simply looks for an optab handler ... the > > operands are not readily available (but their mode is known). > > So I'd create some fake regs, setup operands and call GEN_FCN > > on it?  If it succeds I'd have to delete emitted insns, etc. > > Or I could add a target hook ... > > Hm... indeed, too much complication... > > I'd say, let's go with modeless operands and a target hook. IMO, this > is much more flexible than checking optab for supported modes. > Existing way is appropriate for single mode patterns, but we have > interdependent modes here, at least on x86. > > The hook would have two input arguments, insn mode and compare mode, > where the hook returns suggested supported compare mode, or no mode, > if it really can't handle requested modes. I think a two mode vcond pattern is in fact much cleaner than a one mode + modeless pattern which gen* will complain about and a target hook. Jakub