* [PATCH PING] Remove obsolete alias check in cgraph_redirect_edge_call_stmt_to_callee
@ 2011-08-30 17:46 Martin Jambor
2011-08-31 8:35 ` Richard Guenther
0 siblings, 1 reply; 2+ messages in thread
From: Martin Jambor @ 2011-08-30 17:46 UTC (permalink / raw)
To: GCC Patches; +Cc: Jan Hubicka
Hi,
this is a ping of a patch that I have originally posted almost two
months ago.
Since (same body) aliases have their own cgraph_nodes, the check for
them in cgraph_redirect_edge_call_stmt_to_callee is now unnecessary
because e->callee is now the alias, not the function node.
The following patch therefore removes it. Bootstrapped and tested
again on x86_64-linux yesterday, OK for trunk?
Thanks,
Martin
2011-07-08 Martin Jambor <mjambor@suse.cz>
* cgraphunit.c (cgraph_redirect_edge_call_stmt_to_callee): Alias
check removed.
Index: src/gcc/cgraphunit.c
===================================================================
--- src.orig/gcc/cgraphunit.c
+++ src/gcc/cgraphunit.c
@@ -2373,9 +2373,7 @@ cgraph_redirect_edge_call_stmt_to_callee
#endif
if (e->indirect_unknown_callee
- || decl == e->callee->decl
- /* Don't update call from same body alias to the real function. */
- || (decl && cgraph_get_node (decl) == cgraph_get_node (e->callee->decl)))
+ || decl == e->callee->decl)
return e->call_stmt;
#ifdef ENABLE_CHECKING
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH PING] Remove obsolete alias check in cgraph_redirect_edge_call_stmt_to_callee
2011-08-30 17:46 [PATCH PING] Remove obsolete alias check in cgraph_redirect_edge_call_stmt_to_callee Martin Jambor
@ 2011-08-31 8:35 ` Richard Guenther
0 siblings, 0 replies; 2+ messages in thread
From: Richard Guenther @ 2011-08-31 8:35 UTC (permalink / raw)
To: GCC Patches, Jan Hubicka
On Tue, Aug 30, 2011 at 6:38 PM, Martin Jambor <mjambor@suse.cz> wrote:
>
> Hi,
>
> this is a ping of a patch that I have originally posted almost two
> months ago.
>
> Since (same body) aliases have their own cgraph_nodes, the check for
> them in cgraph_redirect_edge_call_stmt_to_callee is now unnecessary
> because e->callee is now the alias, not the function node.
>
> The following patch therefore removes it. Bootstrapped and tested
> again on x86_64-linux yesterday, OK for trunk?
Ok.
Thanks,
Richard.
> Thanks,
>
> Martin
>
>
> 2011-07-08 Martin Jambor <mjambor@suse.cz>
>
> * cgraphunit.c (cgraph_redirect_edge_call_stmt_to_callee): Alias
> check removed.
>
> Index: src/gcc/cgraphunit.c
> ===================================================================
> --- src.orig/gcc/cgraphunit.c
> +++ src/gcc/cgraphunit.c
> @@ -2373,9 +2373,7 @@ cgraph_redirect_edge_call_stmt_to_callee
> #endif
>
> if (e->indirect_unknown_callee
> - || decl == e->callee->decl
> - /* Don't update call from same body alias to the real function. */
> - || (decl && cgraph_get_node (decl) == cgraph_get_node (e->callee->decl)))
> + || decl == e->callee->decl)
> return e->call_stmt;
>
> #ifdef ENABLE_CHECKING
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-31 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-30 17:46 [PATCH PING] Remove obsolete alias check in cgraph_redirect_edge_call_stmt_to_callee Martin Jambor
2011-08-31 8:35 ` Richard Guenther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).