From: Jakub Jelinek <jakub@redhat.com>
To: Terry Guo <terry.guo@arm.com>
Cc: gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE,
mikestump@comcast.net
Subject: Re: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.
Date: Thu, 01 Sep 2011 06:14:00 -0000 [thread overview]
Message-ID: <20110901061337.GN2687@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <000801cc6847$47460680$d5d21380$@guo@arm.com>
On Thu, Sep 01, 2011 at 09:34:20AM +0800, Terry Guo wrote:
> Here is the patch, is it OK to commit?
Definitely not.
struct-layout-1* already has support for short enums, see
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110247
So, if that doesn't work for you, you need to debug why.
> 2011-08-31 Terry Guo <terry.guo@arm.com>
>
> * gcc.dg/compat/struct-layout-1_main.c: Skip the case
> if the target uses short enums.
>
> diff --git a/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c
> b/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c
> index b59453e..64275ea 100644
> --- a/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c
> +++ b/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c
> @@ -1,4 +1,5 @@
> /* { dg-prune-output ".*-Wno-abi.*" } */
> +/* { dg-skip-if "" { short_enums } } */
>
> #include "struct-layout-1.h"
>
Jakub
next prev parent reply other threads:[~2011-09-01 6:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 1:40 Terry Guo
2011-09-01 6:14 ` Jakub Jelinek [this message]
2011-09-01 6:34 ` Terry Guo
2011-09-01 6:46 ` Jakub Jelinek
2011-09-01 7:10 ` Terry Guo
2011-09-01 7:23 ` Jakub Jelinek
2011-09-01 7:46 ` Terry Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901061337.GN2687@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=terry.guo@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).