From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21715 invoked by alias); 1 Sep 2011 06:14:12 -0000 Received: (qmail 21704 invoked by uid 22791); 1 Sep 2011 06:14:11 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Sep 2011 06:13:48 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p816DeIA016285 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 Sep 2011 02:13:40 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p816DdC8007026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Sep 2011 02:13:40 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p816Dc6C003962; Thu, 1 Sep 2011 08:13:38 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p816DbqM003959; Thu, 1 Sep 2011 08:13:37 +0200 Date: Thu, 01 Sep 2011 06:14:00 -0000 From: Jakub Jelinek To: Terry Guo Cc: gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net Subject: Re: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums. Message-ID: <20110901061337.GN2687@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <000801cc6847$47460680$d5d21380$@guo@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000801cc6847$47460680$d5d21380$@guo@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00002.txt.bz2 On Thu, Sep 01, 2011 at 09:34:20AM +0800, Terry Guo wrote: > Here is the patch, is it OK to commit? Definitely not. struct-layout-1* already has support for short enums, see http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110247 So, if that doesn't work for you, you need to debug why. > 2011-08-31 Terry Guo > > * gcc.dg/compat/struct-layout-1_main.c: Skip the case > if the target uses short enums. > > diff --git a/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c > b/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c > index b59453e..64275ea 100644 > --- a/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c > +++ b/gcc/testsuite/gcc.dg/compat/struct-layout-1_main.c > @@ -1,4 +1,5 @@ > /* { dg-prune-output ".*-Wno-abi.*" } */ > +/* { dg-skip-if "" { short_enums } } */ > > #include "struct-layout-1.h" > Jakub