From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5050 invoked by alias); 1 Sep 2011 07:23:43 -0000 Received: (qmail 5038 invoked by uid 22791); 1 Sep 2011 07:23:41 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Sep 2011 07:23:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p817NGnc028486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 Sep 2011 03:23:16 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p817NFsc010145 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Sep 2011 03:23:16 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p817NEfj004048; Thu, 1 Sep 2011 09:23:14 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p817NEd3004046; Thu, 1 Sep 2011 09:23:14 +0200 Date: Thu, 01 Sep 2011 07:23:00 -0000 From: Jakub Jelinek To: Terry Guo Cc: gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net Subject: Re: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums. Message-ID: <20110901072314.GP2687@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <000801cc6847$47460680$d5d21380$@guo@arm.com> <20110901061337.GN2687@tyan-ft48-01.lab.bos.redhat.com> <000a01cc6870$fc7edc60$f57c9520$@guo@arm.com> <20110901064600.GO2687@tyan-ft48-01.lab.bos.redhat.com> <000b01cc6876$1cbed5c0$563c8140$@guo@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000b01cc6876$1cbed5c0$563c8140$@guo@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00012.txt.bz2 On Thu, Sep 01, 2011 at 03:09:34PM +0800, Terry Guo wrote: > What you said is for compat/struct-layout-1.exp. What I said is for > compat/compat.exp. The case contains three files struct-layout-1_x.c, > struct-layout-1_y.c and struct-layout-1_main.c. All of them are independent > files and not generated by generate.exe. Meanwhile do you think it is > necessary to keep this cases in compat.exp given we already have > struct-layout-1.exp? The files are there to test the infrastructure. I'd say just try 2011-09-01 Jakub Jelinek * gcc.dg/compat/struct-layout-1_test.h: Decrease bitfield size to work even with -fshort-enums. --- gcc/testsuite/gcc.dg/compat/struct-layout-1_test.h 2008-09-05 12:54:32.000000000 +0200 +++ gcc/testsuite/gcc.dg/compat/struct-layout-1_test.h 2011-09-01 09:21:20.200426411 +0200 @@ -1,5 +1 @@ -#if (__SIZEOF_INT__ >= 4) -T(0,enum E2 a:31;,B(0,a,e2_m1,e2_0)) -#else -T(0,enum E2 a:15;,B(0,a,e2_m1,e2_0)) -#endif +T(0,enum E2 a:7;,B(0,a,e2_m1,e2_0)) instead. Jakub