From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19208 invoked by alias); 2 Sep 2011 14:14:49 -0000 Received: (qmail 19196 invoked by uid 22791); 2 Sep 2011 14:14:46 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Sep 2011 14:14:33 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id CF4059AC842; Fri, 2 Sep 2011 16:14:31 +0200 (CEST) Date: Fri, 02 Sep 2011 14:14:00 -0000 From: Jan Hubicka To: Richard Guenther Cc: GCC Patches , Jan Hubicka Subject: Re: [PATCH] Enable IPA-CP on functions with variable number of arguments or type attributes Message-ID: <20110902141431.GC28349@kam.mff.cuni.cz> References: <20110902122701.GA21553@virgil.arch.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00169.txt.bz2 > On Fri, Sep 2, 2011 at 2:27 PM, Martin Jambor wrote: > > Hi, > > > > currently IPA-CP switches itself off on functions with are called with > > variable number of arguments or on those whose signature cannot be > > changed because of type attributes.  This patch turns it on for both, > > not changing the parameters of its clones in the latter case. > > > > Whether the function's signature can be changed is determined by > > looking at node->local.can_change_signature which is set appropriately > > already since my last patch (rev 178386). > > > > This patch also replaces ipa-prop's own node_versionable flag with > > inline_summary (node)->versionable.  Frankly, I find it very confusing > > that this flag is in the inline summary even though it is set in > > ipa-prop (except for thunks - a case we currently never care about > > anyway) and used only in ipa-cp.  I also think this is a property of > > the node (rather than an inlining parameter) as much as > > can_change_signature is - would a patch moving it to node->local be > > acceptable? > > I think so, or even node->global? It is function local property, so node->local. I did the same with can_change_signature, so this is fine with me. They ended up in inline summaries only becuase they used to be computed there. Honza