From: Eric Botcazou <ebotcazou@adacore.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Richard Guenther <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Remove bogus TYPE_IS_SIZETYPE special-casing in extract_muldiv_1
Date: Sat, 03 Sep 2011 15:08:00 -0000 [thread overview]
Message-ID: <201109031708.52403.ebotcazou@adacore.com> (raw)
In-Reply-To: <CAFiYyc22YMnd+iSQt8ABV5upM+w_nq8iZq8-2eNjBO4dO+kcYA@mail.gmail.com>
> Well, for real-world code I believe that. But see all the recent testcases
> for corner-cases of our signed-overflow stuff, they all require
> hand-crafted testcases involving INT_MIN, no inlining and even -ftrapv.
> What I meant to say is, given Ada can construct arbitrary layouted types it
> should be possible to have testcases for all the corner-cases - after all
> you cannot have both, undefined overflow and wrapping overflow, at the same
> time.
Don't forget that we pretend that sizetypes don't overflow; in other words, we
don't support arbitrarily-sized types, so no INT_MAX or something like that.
> Ok, I'll revert it on monday.
Thanks. I'll give the complete patch a try on our internal testsuite.
--
Eric Botcazou
next prev parent reply other threads:[~2011-09-03 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 9:14 Richard Guenther
2011-09-02 8:37 ` Eric Botcazou
2011-09-02 9:05 ` Richard Guenther
2011-09-02 13:26 ` Eric Botcazou
2011-09-02 13:33 ` Richard Guenther
2011-09-03 9:23 ` Eric Botcazou
2011-09-03 11:57 ` Richard Guenther
2011-09-03 15:08 ` Eric Botcazou [this message]
2011-09-03 19:09 ` Richard Guenther
2011-09-03 19:47 ` Richard Kenner
2011-09-03 20:37 ` Richard Guenther
2011-09-03 20:39 ` Richard Guenther
2011-09-03 21:20 ` Richard Kenner
2011-09-03 21:20 ` Richard Kenner
2011-09-03 21:27 ` Richard Kenner
2011-09-05 7:33 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109031708.52403.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).