From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23553 invoked by alias); 3 Sep 2011 15:08:45 -0000 Received: (qmail 23544 invoked by uid 22791); 3 Sep 2011 15:08:44 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Sep 2011 15:08:29 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 0E379CB0214; Sat, 3 Sep 2011 17:08:31 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FS9Bv0pGPfdo; Sat, 3 Sep 2011 17:08:20 +0200 (CEST) Received: from new-host.home (ADijon-552-1-48-137.w92-138.abo.wanadoo.fr [92.138.175.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id ABF13CB016C; Sat, 3 Sep 2011 17:08:20 +0200 (CEST) From: Eric Botcazou To: Richard Guenther Subject: Re: [PATCH] Remove bogus TYPE_IS_SIZETYPE special-casing in extract_muldiv_1 Date: Sat, 03 Sep 2011 15:08:00 -0000 User-Agent: KMail/1.9.9 Cc: Richard Guenther , gcc-patches@gcc.gnu.org References: <201109031124.37807.ebotcazou@adacore.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201109031708.52403.ebotcazou@adacore.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00217.txt.bz2 > Well, for real-world code I believe that. But see all the recent testcases > for corner-cases of our signed-overflow stuff, they all require > hand-crafted testcases involving INT_MIN, no inlining and even -ftrapv. > What I meant to say is, given Ada can construct arbitrary layouted types it > should be possible to have testcases for all the corner-cases - after all > you cannot have both, undefined overflow and wrapping overflow, at the same > time. Don't forget that we pretend that sizetypes don't overflow; in other words, we don't support arbitrarily-sized types, so no INT_MAX or something like that. > Ok, I'll revert it on monday. Thanks. I'll give the complete patch a try on our internal testsuite. -- Eric Botcazou