From: Jakub Jelinek <jakub@redhat.com>
To: Bernd Schmidt <bernds@codesourcery.com>
Cc: Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: ARM: Emit conditions in push_multi
Date: Mon, 12 Sep 2011 11:41:00 -0000 [thread overview]
Message-ID: <20110912093659.GB2687@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <4E67C4B8.7070703@codesourcery.com>
Hi!
This last hunk is wrong, for sprintf you need to use %% instead of %.
On Wed, Sep 07, 2011 at 09:23:36PM +0200, Bernd Schmidt wrote:
> @@ -10631,7 +10633,7 @@ (define_insn "*push_fp_multi"
> {
> char pattern[100];
>
> - sprintf (pattern, \"sfmfd\\t%%1, %d, [%%m0]!\", XVECLEN (operands[2], 0));
> + sprintf (pattern, \"sfm%(fd%)\\t%%1, %d, [%%m0]!\", XVECLEN (operands[2], 0));
> output_asm_insn (pattern, operands);
> return \"\";
> }"
Committed as obvious:
2011-09-12 Jakub Jelinek <jakub@redhat.com>
PR bootstrap/50352
* config/arm/arm.md (*push_fp_multi): Add % before %( and %) in the
sprintf format string.
--- gcc/config/arm/arm.md (revision 178777)
+++ gcc/config/arm/arm.md (revision 178778)
@@ -10633,7 +10633,7 @@ (define_insn "*push_fp_multi"
{
char pattern[100];
- sprintf (pattern, \"sfm%(fd%)\\t%%1, %d, [%%m0]!\", XVECLEN (operands[2], 0));
+ sprintf (pattern, \"sfm%%(fd%%)\\t%%1, %d, [%%m0]!\", XVECLEN (operands[2], 0));
output_asm_insn (pattern, operands);
return \"\";
}"
Jakub
prev parent reply other threads:[~2011-09-12 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 11:53 Bernd Schmidt
2011-09-02 10:35 ` Ramana Radhakrishnan
2011-09-02 11:44 ` Bernd Schmidt
2011-09-07 9:12 ` Ramana Radhakrishnan
2011-09-07 19:36 ` Bernd Schmidt
2011-09-08 8:20 ` Ramana Radhakrishnan
2011-09-12 11:41 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912093659.GB2687@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramana.radhakrishnan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).