* Re: Prevent inliner from removing aliases of used comdats
@ 2011-09-14 19:34 Dmitry Gorbachev
2011-09-14 21:41 ` Jan Hubicka
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Gorbachev @ 2011-09-14 19:34 UTC (permalink / raw)
To: gcc-patches; +Cc: hubicka, graham.stott
Would a testcase from PR50226 suffice?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Prevent inliner from removing aliases of used comdats
2011-09-14 19:34 Prevent inliner from removing aliases of used comdats Dmitry Gorbachev
@ 2011-09-14 21:41 ` Jan Hubicka
0 siblings, 0 replies; 5+ messages in thread
From: Jan Hubicka @ 2011-09-14 21:41 UTC (permalink / raw)
To: Dmitry Gorbachev; +Cc: gcc-patches, hubicka, graham.stott
> Would a testcase from PR50226 suffice?
Sure, fell free to commit it!
Honza
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Prevent inliner from removing aliases of used comdats
2011-09-13 17:55 ` Graham Stott
@ 2011-09-14 9:58 ` Jan Hubicka
0 siblings, 0 replies; 5+ messages in thread
From: Jan Hubicka @ 2011-09-14 9:58 UTC (permalink / raw)
To: Graham Stott; +Cc: gcc-patches, Jan Hubicka
> Jan,
>
> Any testcase do can add?
Sadly not really - in both cases (openoffice and mozilla) the modules involved are too large for testsuite.
I tried to delta it but didn't get anything useful (about 100k of C++)
Honza
>
> Graham
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Prevent inliner from removing aliases of used comdats
2011-09-13 14:43 Jan Hubicka
@ 2011-09-13 17:55 ` Graham Stott
2011-09-14 9:58 ` Jan Hubicka
0 siblings, 1 reply; 5+ messages in thread
From: Graham Stott @ 2011-09-13 17:55 UTC (permalink / raw)
To: gcc-patches, Jan Hubicka
Jan,
Any testcase do can add?
Graham
^ permalink raw reply [flat|nested] 5+ messages in thread
* Prevent inliner from removing aliases of used comdats
@ 2011-09-13 14:43 Jan Hubicka
2011-09-13 17:55 ` Graham Stott
0 siblings, 1 reply; 5+ messages in thread
From: Jan Hubicka @ 2011-09-13 14:43 UTC (permalink / raw)
To: gcc-patches
Hi,
can_remove_node_now_p has two thikos in it that makes it to remove aliases of comdats that eventually may lead to unresolved symbols.
Fixed thus.
Bootstrapped/regtested x86_64-linux, comitted.
Honza
Index: ChangeLog
===================================================================
--- ChangeLog (revision 178808)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2011-09-13 Jan Hubicka <jh@suse.cz>
+
+ PR other/49533
+ * ipa-inline-transform.c (can_remove_node_now_p): Fix thunkos.
+
2011-09-13 Paul Brook <paul@codesourcery.com>
* config/arm/arm.h (ASM_PREFERRED_EH_DATA_FORMAT): Define.
Index: ipa-inline-transform.c
===================================================================
--- ipa-inline-transform.c (revision 178808)
+++ ipa-inline-transform.c (working copy)
@@ -120,8 +120,8 @@ can_remove_node_now_p (struct cgraph_nod
return true;
for (next = node->same_comdat_group;
next != node; next = next->same_comdat_group)
- if (node->callers && node->callers != e
- && !can_remove_node_now_p_1 (node))
+ if ((next->callers && next->callers != e)
+ || !can_remove_node_now_p_1 (next))
return false;
return true;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-14 19:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-14 19:34 Prevent inliner from removing aliases of used comdats Dmitry Gorbachev
2011-09-14 21:41 ` Jan Hubicka
-- strict thread matches above, loose matches on Subject: below --
2011-09-13 14:43 Jan Hubicka
2011-09-13 17:55 ` Graham Stott
2011-09-14 9:58 ` Jan Hubicka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).