From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14231 invoked by alias); 23 Sep 2011 02:32:59 -0000 Received: (qmail 14171 invoked by uid 22791); 23 Sep 2011 02:32:57 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Sep 2011 02:32:42 +0000 Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.5/8.14.5) with ESMTP id p8N2Wfx6074648; Thu, 22 Sep 2011 19:32:41 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.5/8.14.5/Submit) id p8N2WeZC074647; Thu, 22 Sep 2011 19:32:40 -0700 (PDT) (envelope-from sgk) Date: Fri, 23 Sep 2011 07:36:00 -0000 From: Steve Kargl To: Mikael Morin Cc: gfortran , GCC patches Subject: Re: [Patch, fortran] [00/21] Remove coarray support in the scalarizer Message-ID: <20110923023240.GA74631@troutmask.apl.washington.edu> References: <20110915230813.28513.97419@gimli.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110915230813.28513.97419@gimli.local> User-Agent: Mutt/1.4.2.3i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01381.txt.bz2 On Fri, Sep 16, 2011 at 01:08:13AM +0200, Mikael Morin wrote: > Hello, > > the scalarizer is there to generate loops for assignments over more than > one element. Tobias extended it at various places to support coarrays, > but this should not be necessary as coarrays in assignments either refer > to the array present on the local image or to the one on the remote image > (in which case a local temporary is created). In either case the coarray > is seen as a normal array by the assignment code, which makes the point > of having coarray-specific handling in the scalarizer moot. > > In fact the reason for the presence of coarrays in the scalarizer is that > gfc_conv_expr_descriptor uses the scalarizer to setup array (co)bounds. > > This patch serie removes the coarray-specific code in the scalarizer, and > replaces it with some additional cobound setup code in gfc_conv_expr_descriptor. > It is supposed to make the code easier to grasp by having a scalarizer free of > coarray stuff (it is complicated enough without it), and by having cobound > setup code gathered in a single place. > The downside is that it makes gfc_conv_expr_descriptor even bigger than it was > already. > > Every patch has been tested by incremental bootstrap and running the fortran > testsuite with RUNTESTLAGS=caf.exp and RUNTESTFLAGS="dg.exp=*coarray*". > The last one has also passed a full fortran regression test. > > OK for trunk? > I've read through the first 10 patches, and in general I like the clean separation that you're trying to achieve. Given that this effects co-arrays I was expecting Tobias to quickly respond, but it seems he is busy with other obligations. I'll try to go through the entire patch set on Saturday. -- Steve