From: Jakub Jelinek <jakub@redhat.com>
To: Cary Coutant <ccoutant@google.com>, Ian Lance Taylor <iant@google.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
Date: Fri, 23 Sep 2011 08:42:00 -0000 [thread overview]
Message-ID: <20110923074928.GP2687@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <CAHACq4qJ+yxHixtf_xud+rphr4N2=Qwbv3mS=YC2ezzfwiw6Yg@mail.gmail.com>
On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote:
> > Ping?
> >
> > http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html
It looks good to me, but I'd prefer if Ian with his demangler author
and libiberty maintainer hats looked at it too.
> > include/ChangeLog:
> >
> > Â Â Â Â PR 40831
> > Â Â Â Â * demangle.h (enum demangle_component_type): Add
> > Â Â Â Â DEMANGLE_COMPONENT_CLONE.
> >
> > libiberty/ChangeLog:
> >
> > Â Â Â Â PR 40831
> > Â Â Â Â * cp-demangle.c (d_make_comp): Add new component type.
> > Â Â Â Â (cplus_demangle_mangled_name): Check for clone suffixes.
> > Â Â Â Â (d_parmlist): Don't error out if we see '.'.
> > Â Â Â Â (d_clone_suffix): New function.
> > Â Â Â Â (d_print_comp): Print info for clone suffixes.
> > Â Â Â Â * testsuite/demangle-expected: Add new testcases.
Maybe the testcase should test also
_Z2f1IiEvT_S0_S0_._omp_fn.2
_Z3fooi._omp_cpyfn.6
as examples of OpenMP suffixing - the former is an example of name
used for outlined #pragma omp {parallel,task} region from a function
and the latter is for copy constructors needed for #pragma omp task.
Jakub
next prev parent reply other threads:[~2011-09-23 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 5:59 Cary Coutant
2011-09-23 8:42 ` Jakub Jelinek [this message]
2011-09-23 15:54 ` Ian Lance Taylor
2011-09-23 22:25 ` Cary Coutant
2011-09-23 23:46 ` Cary Coutant
2011-09-24 9:08 ` Ian Lance Taylor
2011-09-26 20:03 ` Cary Coutant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110923074928.GP2687@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=ccoutant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).