From: Paul Brook <paul@codesourcery.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>
Cc: Nick Clifton <nickc@redhat.com>,
richard.earnshaw@arm.com, gcc-patches@gcc.gnu.org
Subject: Re: RFC: ARM: Add comment enumerating emitted .eabi_attribute tags
Date: Tue, 27 Sep 2011 16:58:00 -0000 [thread overview]
Message-ID: <201109271655.38344.paul@codesourcery.com> (raw)
In-Reply-To: <CACUk7=ULgCbe2VTvvznZbN+s8qR=C0i35T=VUJJ_5FyMnhEzng@mail.gmail.com>
> Hi Nick,
>
> On 27 September 2011 15:38, Nick Clifton <nickc@redhat.com> wrote:
> > Any comments or objections to this patch ? If not, I will apply it
> > next week.
>
> I've got a few objections to this patch as it stands today while I
> don't object to the motivation for it.
>
> > +/* Get the definitions of the ARM EABI Attribute tag values. */
> > +#define BFD_ARCH_SIZE
> > +#include "elf/arm.h"
>
> Defining BFD_ARCH_SIZE appears to be a bit of a hack. I would also
> ifdef this inclusion on TARGET_AAPCS since we shouldn't really be
> caring about object attributes for non AAPCS configurations.
TARGET_AAPCS doesn't exist. If you mean TARGET_AAPCS_BASED then this is a
runtime expression and can't be used for preprocessor conditionals. Either
way I don't think we really care. The important thing is that we only emit
the .eabi_attribute directives on EABI based targets.
A more important consideration is that this file does not exist.
Nick: Where are you expecting elf/arm.h come from? I can't find any evidence
this exists outside the binutils source tree, and that is not available when
building gcc. The BFD_ARCH_SIZE hack is a fair indication that it isn't
intended to be used elsewhere.
Paul
next prev parent reply other threads:[~2011-09-27 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 15:51 Nick Clifton
2011-09-27 16:47 ` Ramana Radhakrishnan
2011-09-27 16:58 ` Paul Brook [this message]
2011-09-27 17:01 ` Ramana Radhakrishnan
2011-09-27 17:17 ` Nick Clifton
2011-09-27 18:19 ` Paul Brook
2011-09-27 16:49 ` Richard Henderson
2011-09-27 17:23 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109271655.38344.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nickc@redhat.com \
--cc=ramana.radhakrishnan@linaro.org \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).