From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23471 invoked by alias); 27 Sep 2011 15:56:00 -0000 Received: (qmail 23463 invoked by uid 22791); 27 Sep 2011 15:55:58 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Sep 2011 15:55:42 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1R8a0S-0001Fi-M8 from Paul_Brook@mentor.com ; Tue, 27 Sep 2011 08:55:40 -0700 Received: from nowt.org ([172.30.64.129]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 27 Sep 2011 16:55:39 +0100 Received: from wren.localnet (wren.home [192.168.93.7]) by nowt.org (Postfix) with ESMTP id CDCDA6EF87; Tue, 27 Sep 2011 16:55:38 +0100 (BST) From: Paul Brook To: Ramana Radhakrishnan Subject: Re: RFC: ARM: Add comment enumerating emitted .eabi_attribute tags Date: Tue, 27 Sep 2011 16:58:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.0.0-1-amd64; KDE/4.6.5; x86_64; ; ) Cc: Nick Clifton , richard.earnshaw@arm.com, gcc-patches@gcc.gnu.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201109271655.38344.paul@codesourcery.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01741.txt.bz2 > Hi Nick, > > On 27 September 2011 15:38, Nick Clifton wrote: > > Any comments or objections to this patch ? If not, I will apply it > > next week. > > I've got a few objections to this patch as it stands today while I > don't object to the motivation for it. > > > +/* Get the definitions of the ARM EABI Attribute tag values. */ > > +#define BFD_ARCH_SIZE > > +#include "elf/arm.h" > > Defining BFD_ARCH_SIZE appears to be a bit of a hack. I would also > ifdef this inclusion on TARGET_AAPCS since we shouldn't really be > caring about object attributes for non AAPCS configurations. TARGET_AAPCS doesn't exist. If you mean TARGET_AAPCS_BASED then this is a runtime expression and can't be used for preprocessor conditionals. Either way I don't think we really care. The important thing is that we only emit the .eabi_attribute directives on EABI based targets. A more important consideration is that this file does not exist. Nick: Where are you expecting elf/arm.h come from? I can't find any evidence this exists outside the binutils source tree, and that is not available when building gcc. The BFD_ARCH_SIZE hack is a fair indication that it isn't intended to be used elsewhere. Paul