From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: ramana.radhakrishnan@linaro.org (Ramana Radhakrishnan)
Cc: gcc-patches@gcc.gnu.org, rearnsha@arm.com, patches@linaro.org
Subject: Re: [patch, arm] Fix PR target/50305 (arm_legitimize_reload_address problem)
Date: Tue, 04 Oct 2011 15:22:00 -0000 [thread overview]
Message-ID: <201110041513.p94FDVve022537@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <CACUk7=U3uiTLZjCRHznkUYhFNFJA7XpzTqV=VuMCsgU+uCK4GQ@mail.gmail.com> from "Ramana Radhakrishnan" at Sep 26, 2011 05:23:40 PM
Ramana Radhakrishnan wrote:
> On 26 September 2011 15:24, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> > Is this sufficient, or should I test any other set of options as well?
>
> Could you run one set of tests with neon ?
Sorry for the delay, but I had to switch to my IGEP board for Neon
support, and that's a bit slow ... In any case, I've now completed
testing the patch with Neon with no regressions.
> > Just to clarify: in the presence of the other options that are already
> > in dg-options, the test case now fails (with the unpatched compiler)
> > for *any* setting of -mfloat-abi (hard, soft, or softfp). Do you still
> > want me to add a specific setting to the test case?
>
> No the mfpu=vfpv3 is fine.
OK, thanks.
> Instead of skipping I was wondering if we
> could prune the outputs to get this through all the testers we have.
Well, the problem is that with certain -march options (e.g. armv7) we get:
/home/uweigand/gcc-head/gcc/testsuite/gcc.target/arm/pr50305.c:1:0:
error: target CPU does not support ARM mode
Since this is an *error*, pruning the output doesn't really help, the
test isn't being run in any case.
> Otherwise this is OK.
Given the above, is the patch now OK as-is?
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-10-04 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 18:14 Ulrich Weigand
2011-09-11 23:26 ` Michael Hope
2011-09-23 17:28 ` Ulrich Weigand
2011-09-26 10:26 ` Ramana Radhakrishnan
2011-09-26 14:55 ` Ulrich Weigand
2011-09-26 18:02 ` Ramana Radhakrishnan
2011-10-04 15:22 ` Ulrich Weigand [this message]
2011-10-06 9:28 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110041513.p94FDVve022537@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=patches@linaro.org \
--cc=ramana.radhakrishnan@linaro.org \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).