From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12016 invoked by alias); 10 Oct 2011 13:50:31 -0000 Received: (qmail 11675 invoked by uid 22791); 10 Oct 2011 13:50:30 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from atrey.karlin.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.26.193) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Oct 2011 13:50:11 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 81F12F09D5; Mon, 10 Oct 2011 15:50:10 +0200 (CEST) Date: Mon, 10 Oct 2011 13:58:00 -0000 From: Jan Hubicka To: Andi Kleen Cc: gcc-patches@gcc.gnu.org, Andi Kleen Subject: Re: [PATCH 2/5] Increase the GGC quite size to 2MB Message-ID: <20111010135009.GB18476@atrey.karlin.mff.cuni.cz> References: <1318190141-1220-1-git-send-email-andi@firstfloor.org> <1318190141-1220-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1318190141-1220-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg00769.txt.bz2 > From: Andi Kleen > > Using 2MB allows modern kernels to use 2MB huge pages on x86. > > gcc/: > > 2011-10-08 Andi Kleen > > * ggc-page.c (GGC_QUIRE_SIZE): Increase to 512 > --- > gcc/ggc-page.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gcc/ggc-page.c b/gcc/ggc-page.c > index b0b3b3f..1f52b56 100644 > --- a/gcc/ggc-page.c > +++ b/gcc/ggc-page.c > @@ -469,7 +469,7 @@ static struct globals > can override this by defining GGC_QUIRE_SIZE explicitly. */ > #ifndef GGC_QUIRE_SIZE > # ifdef USING_MMAP > -# define GGC_QUIRE_SIZE 256 > +# define GGC_QUIRE_SIZE 512 /* 2MB for 4K pages */ Perhaps comment that 2MB was chosen to help Kernel huge pages logic? Honza > # else > # define GGC_QUIRE_SIZE 16 > # endif > -- > 1.7.5.4