From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17586 invoked by alias); 20 Oct 2011 17:32:50 -0000 Received: (qmail 17576 invoked by uid 22791); 20 Oct 2011 17:32:49 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 17:32:32 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id CE12F19D99; Thu, 20 Oct 2011 19:32:28 +0200 (CEST) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gr7ilX+jPNaO; Thu, 20 Oct 2011 19:32:28 +0200 (CEST) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by anubis.se.axis.com (Postfix) with ESMTP id B3ECB19D83; Thu, 20 Oct 2011 19:32:27 +0200 (CEST) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id 86C9134168; Thu, 20 Oct 2011 19:32:27 +0200 (CEST) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id p9KHWRF6001598; Thu, 20 Oct 2011 19:32:27 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id p9KHWRhv001594; Thu, 20 Oct 2011 19:32:27 +0200 Date: Thu, 20 Oct 2011 19:34:00 -0000 Message-Id: <201110201732.p9KHWRhv001594@ignucius.se.axis.com> From: Hans-Peter Nilsson To: hubicka@ucw.cz CC: gcc-patches@gcc.gnu.org, dnovillo@google.com, rguenther@suse.de, ak@linux.intel.com In-reply-to: <20110927172322.GA21068@kam.mff.cuni.cz> (message from Jan Hubicka on Tue, 27 Sep 2011 19:23:22 +0200) Subject: Breakage with "Update testsuite to run with slim LTO" MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01893.txt.bz2 > Date: Tue, 27 Sep 2011 19:23:22 +0200 > From: Jan Hubicka > this patch updates testsuite to cover both fat and slim LTO when linker plugin > is used and also both linker plugin and collect2 paths. I didn't wanted to > slow down testing too much so I just distributes the flags across existing runs > with aim to maximize the coverage of testing matrix that is bit large now. > I believe it is sufficient and testsuite now runs a bit faster than previously > since slim LTO saves some effort. > > sync and pr34850 tests doesn't pass with slim LTO. The reason is that they > excpects diagnostics that is output too late in compilation (usually at > expansion time). These should be probably fixed as QOI issue but they are not > real bug - the diagnostics will be output at linktime. I will open PR tracking > this. We probably should output pretty much everything till end of early opts > except for stuff that really looks for optimization results. Especially now > when we handle always inline in early inlining. > > Honza > > * lib/lto.exp: When linker plugin is available test both > plugin/non-plugin LTO paths as well as fat and slim LTO. > lib/c-torture.exp: Likewise. > lib/gcc-dg.exp: Likweise Looks like this patch broke, for cris-elf with TOT binutils: Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/torture/dg-torture.exp ... FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler in-asm: .mof FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler out-asm: .mof FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler in2-asm: .mof FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler out2-asm: .mof which for "-O2 -flto -fuse-linker-plugin -fno-fat-lto-objects" don't produce any code. Is that expected? If so, and if the required update is as for the test-cases you updated, to add: + /* { dg-options "-ffat-lto-objects" } */ then IIUC you need to patch *all* torture tests that use scan-assembler and scan-assembler-not. Alternatively, patch somewhere else, like not passing it if certain directives are used, like scan-assembler{,-not}. And either way, is it safe to add that option always, not just when also passing "-flto" or something? brgds, H-P