From: Jan Hubicka <hubicka@ucw.cz>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: hubicka@ucw.cz, gcc-patches@gcc.gnu.org, dnovillo@google.com,
rguenther@suse.de, ak@linux.intel.com
Subject: Re: Breakage with "Update testsuite to run with slim LTO"
Date: Fri, 21 Oct 2011 00:39:00 -0000 [thread overview]
Message-ID: <20111020221932.GA13355@kam.mff.cuni.cz> (raw)
In-Reply-To: <201110201732.p9KHWRhv001594@ignucius.se.axis.com>
> > Date: Tue, 27 Sep 2011 19:23:22 +0200
> > From: Jan Hubicka <hubicka@ucw.cz>
>
> > this patch updates testsuite to cover both fat and slim LTO when linker plugin
> > is used and also both linker plugin and collect2 paths. I didn't wanted to
> > slow down testing too much so I just distributes the flags across existing runs
> > with aim to maximize the coverage of testing matrix that is bit large now.
> > I believe it is sufficient and testsuite now runs a bit faster than previously
> > since slim LTO saves some effort.
> >
> > sync and pr34850 tests doesn't pass with slim LTO. The reason is that they
> > excpects diagnostics that is output too late in compilation (usually at
> > expansion time). These should be probably fixed as QOI issue but they are not
> > real bug - the diagnostics will be output at linktime. I will open PR tracking
> > this. We probably should output pretty much everything till end of early opts
> > except for stuff that really looks for optimization results. Especially now
> > when we handle always inline in early inlining.
> >
> > Honza
> >
> > * lib/lto.exp: When linker plugin is available test both
> > plugin/non-plugin LTO paths as well as fat and slim LTO.
> > lib/c-torture.exp: Likewise.
> > lib/gcc-dg.exp: Likweise
>
> Looks like this patch broke, for cris-elf with TOT binutils:
>
> Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/torture/dg-torture.exp ...
> FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler in-asm: .mof
> FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler out-asm: .mof
> FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler in2-asm: .mof
> FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler out2-asm: .mof
>
> which for "-O2 -flto -fuse-linker-plugin -fno-fat-lto-objects"
> don't produce any code. Is that expected?
>
> If so, and if the required update is as for the test-cases you
> updated, to add:
> + /* { dg-options "-ffat-lto-objects" } */
Yes, if we scan assembler, we likely want -fno-fat-lto-objects.
>
> then IIUC you need to patch *all* torture tests that use
> scan-assembler and scan-assembler-not. Alternatively, patch
> somewhere else, like not passing it if certain directives are
> used, like scan-assembler{,-not}. And either way, is it safe to
> add that option always, not just when also passing "-flto" or
> something?
Hmm, some of assembler scans still works because they check for
presence of symbols we output anyway, but indeed, it would make more
sense to automatically imply -ffat-lto-object when scan-assembler
is used. I am not sure if my dejagnu skill as on par here however.
Honza
>
> brgds, H-P
next prev parent reply other threads:[~2011-10-20 22:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 17:54 Update testsuite to run with slim LTO Jan Hubicka
2011-09-30 14:56 ` Diego Novillo
2011-10-20 19:34 ` Breakage with "Update testsuite to run with slim LTO" Hans-Peter Nilsson
2011-10-20 19:53 ` Andi Kleen
2011-10-21 0:39 ` Jan Hubicka [this message]
2011-10-21 5:22 ` [RFA:] fix breakage " Hans-Peter Nilsson
2011-10-21 9:58 ` Jan Hubicka
2011-10-21 12:23 ` Iain Sandoe
2011-10-21 12:35 ` Rainer Orth
2011-10-21 16:20 ` Jan Hubicka
2011-10-21 17:40 ` Hans-Peter Nilsson
2011-10-21 18:52 ` Jan Hubicka
2011-10-21 19:56 ` Hans-Peter Nilsson
2011-10-24 12:08 ` Richard Guenther
2011-10-28 14:59 ` ping: [RFA:] testsuite infrastructure for options implied by dg-final methods Hans-Peter Nilsson
2011-11-04 13:56 ` ping*2: " Hans-Peter Nilsson
2011-11-04 17:05 ` Mike Stump
2011-11-04 17:54 ` Hans-Peter Nilsson
2011-11-04 18:14 ` Mike Stump
2011-11-04 18:16 ` Hans-Peter Nilsson
2023-05-03 11:16 ` Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS' (was: Update testsuite to run with slim LTO) Thomas Schwinge
2023-05-03 11:46 ` Richard Biener
2023-05-09 7:32 ` Christophe Lyon
2023-05-09 9:00 ` Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS') Thomas Schwinge
2023-05-09 15:17 ` Christophe Lyon
2023-05-09 19:14 ` Christophe Lyon
2023-05-10 7:51 ` Testsuite: Add 'torture-init-done', and use it to conditionalize implicit 'torture-init' (was: Testsuite: Add missing 'torture-init'/'torture-finish' around 'LTO_TORTURE_OPTIONS' usage (was: Let each 'lto_init' determine the default 'LTO_OPTIONS', and 'torture-init' the 'LTO_TORTURE_OPTIONS')) Thomas Schwinge
2023-05-10 13:42 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020221932.GA13355@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=ak@linux.intel.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).