From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29288 invoked by alias); 20 Oct 2011 22:19:51 -0000 Received: (qmail 29277 invoked by uid 22791); 20 Oct 2011 22:19:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 22:19:33 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 75D8B9AC70E; Fri, 21 Oct 2011 00:19:32 +0200 (CEST) Date: Fri, 21 Oct 2011 00:39:00 -0000 From: Jan Hubicka To: Hans-Peter Nilsson Cc: hubicka@ucw.cz, gcc-patches@gcc.gnu.org, dnovillo@google.com, rguenther@suse.de, ak@linux.intel.com Subject: Re: Breakage with "Update testsuite to run with slim LTO" Message-ID: <20111020221932.GA13355@kam.mff.cuni.cz> References: <20110927172322.GA21068@kam.mff.cuni.cz> <201110201732.p9KHWRhv001594@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110201732.p9KHWRhv001594@ignucius.se.axis.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01914.txt.bz2 > > Date: Tue, 27 Sep 2011 19:23:22 +0200 > > From: Jan Hubicka > > > this patch updates testsuite to cover both fat and slim LTO when linker plugin > > is used and also both linker plugin and collect2 paths. I didn't wanted to > > slow down testing too much so I just distributes the flags across existing runs > > with aim to maximize the coverage of testing matrix that is bit large now. > > I believe it is sufficient and testsuite now runs a bit faster than previously > > since slim LTO saves some effort. > > > > sync and pr34850 tests doesn't pass with slim LTO. The reason is that they > > excpects diagnostics that is output too late in compilation (usually at > > expansion time). These should be probably fixed as QOI issue but they are not > > real bug - the diagnostics will be output at linktime. I will open PR tracking > > this. We probably should output pretty much everything till end of early opts > > except for stuff that really looks for optimization results. Especially now > > when we handle always inline in early inlining. > > > > Honza > > > > * lib/lto.exp: When linker plugin is available test both > > plugin/non-plugin LTO paths as well as fat and slim LTO. > > lib/c-torture.exp: Likewise. > > lib/gcc-dg.exp: Likweise > > Looks like this patch broke, for cris-elf with TOT binutils: > > Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/torture/dg-torture.exp ... > FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler in-asm: .mof > FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler out-asm: .mof > FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler in2-asm: .mof > FAIL: gcc.dg/torture/cris-asm-mof-1.c scan-assembler out2-asm: .mof > > which for "-O2 -flto -fuse-linker-plugin -fno-fat-lto-objects" > don't produce any code. Is that expected? > > If so, and if the required update is as for the test-cases you > updated, to add: > + /* { dg-options "-ffat-lto-objects" } */ Yes, if we scan assembler, we likely want -fno-fat-lto-objects. > > then IIUC you need to patch *all* torture tests that use > scan-assembler and scan-assembler-not. Alternatively, patch > somewhere else, like not passing it if certain directives are > used, like scan-assembler{,-not}. And either way, is it safe to > add that option always, not just when also passing "-flto" or > something? Hmm, some of assembler scans still works because they check for presence of symbols we output anyway, but indeed, it would make more sense to automatically imply -ffat-lto-object when scan-assembler is used. I am not sure if my dejagnu skill as on par here however. Honza > > brgds, H-P