From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23324 invoked by alias); 21 Oct 2011 09:31:28 -0000 Received: (qmail 23314 invoked by uid 22791); 21 Oct 2011 09:31:28 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Oct 2011 09:31:13 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 796339AC75C; Fri, 21 Oct 2011 11:31:12 +0200 (CEST) Date: Fri, 21 Oct 2011 09:58:00 -0000 From: Jan Hubicka To: Hans-Peter Nilsson Cc: hubicka@ucw.cz, hp@axis.com, gcc-patches@gcc.gnu.org, dnovillo@google.com, rguenther@suse.de, ak@linux.intel.com Subject: Re: [RFA:] fix breakage with "Update testsuite to run with slim LTO" Message-ID: <20111021093112.GD2976@kam.mff.cuni.cz> References: <20111020221932.GA13355@kam.mff.cuni.cz> <201110210229.p9L2TKmx010677@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110210229.p9L2TKmx010677@ignucius.se.axis.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01943.txt.bz2 > > Date: Fri, 21 Oct 2011 00:19:32 +0200 > > From: Jan Hubicka > > Yes, if we scan assembler, we likely want -fno-fat-lto-objects. > > > > then IIUC you need to patch *all* torture tests that use > > > scan-assembler and scan-assembler-not. Alternatively, patch > > > somewhere else, like not passing it if certain directives are > > > used, like scan-assembler{,-not}. And either way, is it safe to > > > add that option always, not just when also passing "-flto" or > > > something? > > > > Hmm, some of assembler scans still works because they check for > > presence of symbols we output anyway, but indeed, it would make more > > sense to automatically imply -ffat-lto-object when scan-assembler > > is used. I am not sure if my dejagnu skill as on par here however. > > Maybe you could make amends ;) by testing the following, which > seems to work at least for dg-torture.exp and cris-elf/cris-sim, > in which -ffat-lto-object is automatically added for each > scan-assembler and scan-assembler-not test, extensible for other > dg-final actions without polluting with checking LTO options and > whatnot across the files. I checked (and corrected) so it also > works when !check_effective_target_lto by commenting out the > setting in the second chunk. Thanks. It looks good to me. If we ever start scanning LTO assembler output, we may simply add scan-lto-assembler variants or so... Honza